Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): Consolidate C/C++ coverage generation in new CI workflow #14127

Merged
merged 1 commit into from
Oct 26, 2022
Merged

chore(ci): Consolidate C/C++ coverage generation in new CI workflow #14127

merged 1 commit into from
Oct 26, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Oct 11, 2022 •
edited

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@LKreutzer LKreutzer added component: ci All updates on CI (Jenkins/CircleCi/Github Action) bazel changes for the Bazelification effort labels Oct 11, 2022
@LKreutzer LKreutzer self-assigned this Oct 11, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Oct 11, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022 •
edited

dp-workflow

14 tests   14 ✔️  2m 5s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit bd0aae4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022 •
edited

agw-workflow

615 tests   611 ✔️  3m 53s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit bd0aae4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022 •
edited

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit bd0aae4.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2022 •
edited

cloud-workflow

1 135 tests   1 135 ✔️  2m 16s ⏱️
   365 suites         0 💤
       7 files           0 ❌

Results for commit bd0aae4.

♻️ This comment has been updated with latest results.

@LKreutzer
Copy link
Contributor Author

Rebased

@LKreutzer LKreutzer force-pushed the consolidate_codecov_bazel branch 2 times, most recently from 086794c to 5ea2af4 Compare October 25, 2022 11:35
@LKreutzer LKreutzer requested a review from nstng October 25, 2022 12:41
@LKreutzer LKreutzer marked this pull request as ready for review October 25, 2022 12:41
@LKreutzer LKreutzer requested a review from a team as a code owner October 25, 2022 12:41
@LKreutzer LKreutzer mentioned this pull request Oct 25, 2022
Merged
1 task
Neudrino
Neudrino requested changes Oct 25, 2022
View reviewed changes
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the python workflow it is pretty much the same as for C++ workflow.

.github/workflows/agw-coverage.yml Outdated Show resolved Hide resolved
.github/workflows/agw-coverage.yml Outdated Show resolved Hide resolved
.github/workflows/agw-coverage.yml Outdated Show resolved Hide resolved
.github/workflows/agw-coverage.yml Outdated Show resolved Hide resolved
.github/workflows/agw-coverage.yml Outdated Show resolved Hide resolved
Neudrino
Neudrino reviewed Oct 26, 2022
View reviewed changes
.github/workflows/agw-coverage.yml Outdated Show resolved Hide resolved
.github/workflows/agw-coverage.yml Outdated Show resolved Hide resolved
@LKreutzer LKreutzer force-pushed the consolidate_codecov_bazel branch 2 times, most recently from 4f3b091 to eec70df Compare October 26, 2022 11:23
Neudrino
Neudrino approved these changes Oct 26, 2022
View reviewed changes
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow up this might be a nice opportunity to abstract a bit to reduce the large amount of duplication.

@LKreutzer
chore(ci): Consolidate C/C++ and python code coverage generation in n…
bd0aae4 
…ew CI workflow

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer requested a review from nstng October 26, 2022 12:24
@LKreutzer LKreutzer merged commit 3a90b1a into magma:master Oct 26, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@LKreutzer @lucasgonze
chore(ci): Consolidate C/C++ and python code coverage generation in n…
91fbd76 
…ew CI workflow (magma#14127)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neudrino Neudrino Neudrino approved these changes

@voisey voisey voisey left review comments

@nstng nstng Awaiting requested review from nstng

Assignees

@LKreutzer LKreutzer

Labels
bazel changes for the Bazelification effort component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate coverage generation
4 participants
@LKreutzer @Neudrino @voisey @nstng