Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(lte): Remove Make coverage targets for LTE #14264

Merged
merged 1 commit into from
Nov 16, 2022
Merged

chore(lte): Remove Make coverage targets for LTE #14264

merged 1 commit into from
Nov 16, 2022

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Oct 25, 2022 •
edited
Loading

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

@LKreutzer LKreutzer added the bazel-cleanup BE fixups that came out of the Bazelification effort label Oct 25, 2022
@LKreutzer LKreutzer self-assigned this Oct 25, 2022
@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Oct 25, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: ci All updates on CI (Jenkins/CircleCi/Github Action) labels Oct 25, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022 •
edited
Loading

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs  388 ✔️ 0 💤 0 ❌

Results for commit 88478a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022 •
edited
Loading

dp-workflow

14 tests   14 ✔️  3m 3s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit 88478a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

cloud-workflow

1 135 tests   1 135 ✔️  2m 59s ⏱️
   365 suites         0 💤
       7 files           0 ❌

Results for commit 9d3e83d.

@LKreutzer LKreutzer mentioned this pull request Oct 25, 2022
Closed
6 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2022 •
edited
Loading

agw-workflow

615 tests   611 ✔️  3m 50s ⏱️
    2 suites      4 💤
    2 files        0 ❌

Results for commit 88478a5.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Oct 26, 2022
@LKreutzer LKreutzer marked this pull request as ready for review October 26, 2022 13:42
@LKreutzer LKreutzer requested review from a team October 26, 2022 13:42
@LKreutzer LKreutzer requested a review from a team as a code owner October 26, 2022 13:42
@github-actions github-actions bot removed the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 26, 2022
@LKreutzer LKreutzer requested review from ajahl and removed request for themarwhal and ganeshg87 October 26, 2022 13:43
@LKreutzer
Copy link
Contributor Author

Waiting for approval of approvers-agw-sessiond or until the group has been merged with another approvers group.

@LKreutzer LKreutzer mentioned this pull request Oct 31, 2022
Merged
@LKreutzer LKreutzer mentioned this pull request Nov 8, 2022
Merged
3 tasks
@LKreutzer LKreutzer removed the request for review from themarwhal November 14, 2022 07:47
@LKreutzer LKreutzer added the DONOTLAND Please don't merge this label Nov 14, 2022
@LKreutzer
chore(lte): Remove Make coverage targets for LTE
d1a9c5d 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer removed the DONOTLAND Please don't merge this label Nov 16, 2022
@LKreutzer LKreutzer merged commit a6a2724 into magma:master Nov 16, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
@LKreutzer @lucasgonze
chore(lte): Remove Make coverage targets for LTE (magma#14264)
945b629 
Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajahl ajahl ajahl approved these changes

@Neudrino Neudrino Neudrino approved these changes

Assignees

@LKreutzer LKreutzer

Labels
bazel-cleanup BE fixups that came out of the Bazelification effort component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consolidate coverage generation
3 participants
@LKreutzer @ajahl @Neudrino