Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): remove duplication from fabfile for AGW integration tests #14154

Merged

Conversation

Neudrino
Copy link
Contributor

Summary

  • Unbelievable that the same method was implemented twice. And yes, the deleted lines are in the other workflow as well. They might be one level higher or lower though.

Test Plan

  • CI

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 13, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Oct 13, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 7879869.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

dp-workflow

14 tests   14 ✔️  3m 6s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 7879869.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2022

agw-workflow

615 tests   611 ✔️  3m 48s ⏱️
    2 suites      4 💤
    2 files        0

Results for commit 7879869.

♻️ This comment has been updated with latest results.

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKIV branch from 2fc2207 to 7879869 Compare October 13, 2022 13:27
@Neudrino Neudrino requested review from voisey and ajahl October 13, 2022 13:30
@Neudrino Neudrino marked this pull request as ready for review October 13, 2022 13:31
@Neudrino Neudrino requested a review from a team as a code owner October 13, 2022 13:31
@Neudrino Neudrino merged commit 7e187be into magma:master Oct 13, 2022
@Neudrino Neudrino deleted the ci/refactor-integration-test-makefile-MKIV branch October 13, 2022 16:02
@Neudrino Neudrino self-assigned this Oct 14, 2022
@Neudrino Neudrino linked an issue Oct 14, 2022 that may be closed by this pull request
@Neudrino Neudrino removed their assignment Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw enable stable s1ap tests
2 participants