chore(ci): refactor AGW integration test makefile to handle multiple manual tests correctly #14150

Neudrino · 2022-10-13T07:33:11Z

Summary

allow for multiple tests to be executed manually (space separated)! 🚀
This was previously thought to be possible and also suggested by the naming, but actually not implemented.
clean up bloat

Test Plan

CI

github-actions · 2022-10-13T07:33:24Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2022-10-13T07:48:11Z

feg-workflow

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit 28117d4.

♻️ This comment has been updated with latest results.

lte/gateway/python/integ_tests/Makefile

github-actions · 2022-10-13T08:07:28Z

dp-workflow

14 tests 14 ✔️ 3m 11s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit 28117d4.

♻️ This comment has been updated with latest results.

github-actions · 2022-10-13T08:26:05Z

agw-workflow

615 tests 611 ✔️ 6m 22s ⏱️
    2 suites     4 💤
    2 files     0 ❌

Results for commit 28117d4.

♻️ This comment has been updated with latest results.

mpfirrmann

Two additional comments:

Running make selected_test TESTS=... now loses the information, whether you run these tests in federated mode or not.
The /lte/gateway/fabfile.py also uses the make integ_test TESTS=... and make fed_integ_test TESTS=... handles in several places, which would need to be adapted.

Neudrino · 2022-10-13T12:13:23Z

Two additional comments:

Running make selected_test TESTS=... now loses the information, whether you run these tests in federated mode or not.

The /lte/gateway/fabfile.py also uses the make integ_test TESTS=... and make fed_integ_test TESTS=... handles in several places, which would need to be adapted.

I am aware, but we should go for it anyway, as this is currently not used in CI. This will be fixed, after the profound cleanup, especially after a change like this one, or similar, which dramatically decreases complexity and increases flexibility.
Yes, mostly within the comments of run_integ_test function, which is completely useless and will be removed with chore(ci): remove duplication from fabfile for AGW integration tests #14154.

Neudrino · 2022-10-13T13:32:57Z

Second thought: Let's do it the other way round than and get the fabfile change in first.

chore(ci): remove duplication from fabfile for AGW integration tests #14154

…manual tests correctly Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

Neudrino · 2022-10-17T06:53:51Z

One is now able to run selected integration tests in federated and non-federated mode.

sebathomas

Nice! Would probably be good to notify the dev channel when this is merged.

docs/readmes/feg/s1ap_federated_tests.md

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

…manual tests correctly (magma#14150) * chore(ci): refactor AGW integration test makefile to handle multiple manual tests correctly * chore(ci): adopt documentation to single & multiple test execution Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines. label Oct 13, 2022

github-actions bot added the component: agw Access gateway-related issue label Oct 13, 2022

Neudrino requested a review from mpfirrmann October 13, 2022 07:33

Neudrino marked this pull request as ready for review October 13, 2022 07:33

Neudrino requested a review from a team October 13, 2022 07:33

Neudrino enabled auto-merge (squash) October 13, 2022 07:33

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from d33f5dd to 9779cb2 Compare October 13, 2022 07:34

mpfirrmann requested changes Oct 13, 2022

View reviewed changes

lte/gateway/python/integ_tests/Makefile Show resolved Hide resolved

lte/gateway/python/integ_tests/Makefile Show resolved Hide resolved

lte/gateway/python/integ_tests/Makefile Show resolved Hide resolved

Neudrino requested a review from a team October 13, 2022 10:09

Neudrino requested a review from a team as a code owner October 13, 2022 10:09

Neudrino requested a review from voisey October 13, 2022 10:09

pull-request-size bot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Oct 13, 2022

github-actions bot added the component: docs Documentation-related issue label Oct 13, 2022

Neudrino requested a review from mpfirrmann October 13, 2022 10:12

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from 229664f to a7a699b Compare October 13, 2022 10:32

mpfirrmann requested changes Oct 13, 2022

View reviewed changes

Neudrino requested a review from mpfirrmann October 13, 2022 12:17

Neudrino disabled auto-merge October 13, 2022 13:33

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from a7a699b to aa6a573 Compare October 14, 2022 13:44

Neudrino marked this pull request as draft October 14, 2022 13:46

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from aa6a573 to 0ab5b80 Compare October 14, 2022 14:30

Neudrino mentioned this pull request Oct 14, 2022

refactor(ci): modularize the federated integration test make command #14170

Merged

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from 0ab5b80 to c0b36fa Compare October 17, 2022 06:45

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from c0b36fa to fde84cf Compare October 17, 2022 06:46

chore(ci): refactor AGW integration test makefile to handle multiple …

e249259

…manual tests correctly Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from fde84cf to 68c77a4 Compare October 17, 2022 06:50

Neudrino marked this pull request as ready for review October 17, 2022 06:51

Neudrino enabled auto-merge (squash) October 17, 2022 06:59

sebathomas reviewed Oct 17, 2022

View reviewed changes

docs/readmes/feg/s1ap_federated_tests.md Outdated Show resolved Hide resolved

chore(ci): adopt documentation to single & multiple test execution

28117d4

Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>

Neudrino force-pushed the ci/refactor-integration-test-makefile-MKI branch from 68c77a4 to 28117d4 Compare October 17, 2022 07:20

Neudrino requested a review from sebathomas October 17, 2022 07:20

mpfirrmann approved these changes Oct 17, 2022

View reviewed changes

sebathomas approved these changes Oct 17, 2022

View reviewed changes

voisey approved these changes Oct 17, 2022

View reviewed changes

Neudrino merged commit f741f0f into magma:master Oct 17, 2022

Neudrino deleted the ci/refactor-integration-test-makefile-MKI branch October 17, 2022 08:38

Neudrino linked an issue Oct 17, 2022 that may be closed by this pull request

CI support for dockerized agw enable stable s1ap tests #14123

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(ci): refactor AGW integration test makefile to handle multiple manual tests correctly #14150

chore(ci): refactor AGW integration test makefile to handle multiple manual tests correctly #14150

Neudrino commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

mpfirrmann left a comment

Neudrino commented Oct 13, 2022 •

edited

Neudrino commented Oct 13, 2022

Neudrino commented Oct 17, 2022

sebathomas left a comment

chore(ci): refactor AGW integration test makefile to handle multiple manual tests correctly #14150

chore(ci): refactor AGW integration test makefile to handle multiple manual tests correctly #14150

Conversation

Neudrino commented Oct 13, 2022 • edited

Summary

Test Plan

github-actions bot commented Oct 13, 2022

Howto

More info

github-actions bot commented Oct 13, 2022 • edited

feg-workflow

github-actions bot commented Oct 13, 2022 • edited

dp-workflow

github-actions bot commented Oct 13, 2022 • edited

agw-workflow

mpfirrmann left a comment

Choose a reason for hiding this comment

Neudrino commented Oct 13, 2022 • edited

Neudrino commented Oct 13, 2022

Neudrino commented Oct 17, 2022

sebathomas left a comment

Choose a reason for hiding this comment

Neudrino commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

github-actions bot commented Oct 13, 2022 •

edited

Neudrino commented Oct 13, 2022 •

edited