Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): modularize the federated integration test make command #14170

Merged

Conversation

Neudrino
Copy link
Contributor

@Neudrino Neudrino commented Oct 14, 2022

Summary

Test Plan

  • CI

Additional Information

  • Note that the federated integration tests are flaky anyway, due to issues with VM startup.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 14, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: docs Documentation-related issue labels Oct 14, 2022
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKVI branch from e0e3615 to 39cfa41 Compare October 14, 2022 14:20
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Oct 14, 2022
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKVI branch 2 times, most recently from 15f16f1 to f695c0b Compare October 14, 2022 14:31
@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2022

feg-workflow

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit d297b16.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2022

dp-workflow

14 tests   14 ✔️  2m 14s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit d297b16.

♻️ This comment has been updated with latest results.

@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKVI branch from f695c0b to 1650e04 Compare October 14, 2022 15:14
@Neudrino Neudrino marked this pull request as ready for review October 14, 2022 15:16
@Neudrino Neudrino requested review from a team October 14, 2022 15:16
@Neudrino Neudrino requested a review from a team as a code owner October 14, 2022 15:16
Copy link
Contributor

@mpfirrmann mpfirrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, although I don't see (yet?) the real benefit of having a separate handle for the eval export expression only. But this may be up to personal preference.

@Neudrino Neudrino enabled auto-merge (squash) October 14, 2022 15:43
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKVI branch from 1650e04 to 8e12cce Compare October 14, 2022 16:12
Signed-off-by: Fritz Lehnert <13189449+Neudrino@users.noreply.github.com>
@Neudrino Neudrino force-pushed the ci/refactor-integration-test-makefile-MKVI branch from 8e12cce to d297b16 Compare October 14, 2022 16:12
@Neudrino
Copy link
Contributor Author

Changes LGTM, although I don't see (yet?) the real benefit of having a separate handle for the eval export expression only. But this may be up to personal preference.

@Neudrino Neudrino merged commit d78a0d8 into magma:master Oct 14, 2022
@Neudrino Neudrino deleted the ci/refactor-integration-test-makefile-MKVI branch October 14, 2022 16:58
@Neudrino Neudrino linked an issue Oct 17, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue component: docs Documentation-related issue size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI support for dockerized agw enable stable s1ap tests
3 participants