Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Reconfigure workflow triggers to push on master instead of waiting for the build-all workflow to complete #14227

Merged

Conversation

LKreutzer
Copy link
Contributor

@LKreutzer LKreutzer commented Oct 20, 2022

Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com

Summary

Test Plan

Additional Information

  • The deploy-build-from-pr workflow does indeed seem to require the build-all job.

  • This change is backwards-breaking

@LKreutzer LKreutzer added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 20, 2022
@LKreutzer LKreutzer self-assigned this Oct 20, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines. label Oct 20, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions
Copy link
Contributor

github-actions bot commented Oct 20, 2022

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 6b6185f.

♻️ This comment has been updated with latest results.

@LKreutzer LKreutzer force-pushed the reconfigure_workflow_triggers_build_all branch from 6a39f1f to f4b0398 Compare October 20, 2022 10:53
@LKreutzer LKreutzer marked this pull request as ready for review October 20, 2022 11:34
@LKreutzer LKreutzer requested a review from a team as a code owner October 20, 2022 11:34
Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Have you checked the respective fabfiles and makefile for the workflows if there is really no dependency on prebuild packages?
    • Did not do it for lte-integ-test-bazel and sudo-python-tests, because I believe you had a much closer look at them recently.
  • Do a full text search for github.event_name and github.event.workflow_run in all workflows touched. Those parts will need an update as well.

.github/workflows/agw-docker-load-test.yml Outdated Show resolved Hide resolved
.github/workflows/federated-integ-test.yml Show resolved Hide resolved
.github/workflows/lte-integ-test-bazel.yml Show resolved Hide resolved
.github/workflows/lte-integ-test-containerized.yml Outdated Show resolved Hide resolved
@LKreutzer LKreutzer force-pushed the reconfigure_workflow_triggers_build_all branch from f4b0398 to ff7cfb0 Compare October 20, 2022 12:43
@LKreutzer
Copy link
Contributor Author

Replaced github.event.workflow_run.event == 'push' with github.event_name == 'push'

@LKreutzer LKreutzer force-pushed the reconfigure_workflow_triggers_build_all branch 2 times, most recently from 8430bb6 to de4edd1 Compare October 20, 2022 13:05
@LKreutzer
Copy link
Contributor Author

Removed changes to .github/workflows/lte-integ-test-containerized.yml

Copy link
Contributor

@Neudrino Neudrino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced github.event.workflow_run.event == 'push' with github.event_name == 'push'

I see that I would be a slight function change to not restrict it on push here, but do we really need to exclude the execution of those steps upon workflow_dispatch? If so, why?

.github/workflows/cwf-integ-test.yml Outdated Show resolved Hide resolved
@LKreutzer
Copy link
Contributor Author

Replaced github.event.workflow_run.event == 'push' with github.event_name == 'push'

I see that I would be a slight function change to not restrict it on push here, but do we really need to exclude the execution of those steps upon workflow_dispatch? If so, why?

The steps that require a secret will fail if you run the workflow on a fork without the secrets.

@LKreutzer LKreutzer force-pushed the reconfigure_workflow_triggers_build_all branch from de4edd1 to 5531cc1 Compare October 24, 2022 07:58
@LKreutzer
Copy link
Contributor Author

Replaced env.SHA with github.sha.

… waiting for the build-all workflow to complete

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
@LKreutzer LKreutzer force-pushed the reconfigure_workflow_triggers_build_all branch from 62a1f98 to 6b6185f Compare October 25, 2022 11:46
@LKreutzer LKreutzer merged commit cafcace into magma:master Oct 25, 2022
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
… waiting for the build-all workflow to complete (magma#14227)

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>

Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and reconfigure integ test workflow triggers
2 participants