-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): Reconfigure workflow triggers to push on master instead of waiting for the build-all workflow to complete #14227
chore(ci): Reconfigure workflow triggers to push on master instead of waiting for the build-all workflow to complete #14227
Conversation
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
6a39f1f
to
f4b0398
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Have you checked the respective fabfiles and makefile for the workflows if there is really no dependency on prebuild packages?
- Did not do it for
lte-integ-test-bazel
andsudo-python-tests
, because I believe you had a much closer look at them recently.
- Did not do it for
- Do a full text search for
github.event_name
andgithub.event.workflow_run
in all workflows touched. Those parts will need an update as well.
f4b0398
to
ff7cfb0
Compare
Replaced |
8430bb6
to
de4edd1
Compare
Removed changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replaced
github.event.workflow_run.event == 'push'
withgithub.event_name == 'push'
I see that I would be a slight function change to not restrict it on push
here, but do we really need to exclude the execution of those steps upon workflow_dispatch
? If so, why?
The steps that require a secret will fail if you run the workflow on a fork without the secrets. |
de4edd1
to
5531cc1
Compare
Replaced |
5531cc1
to
62a1f98
Compare
… waiting for the build-all workflow to complete Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
62a1f98
to
6b6185f
Compare
… waiting for the build-all workflow to complete (magma#14227) Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com> Signed-off-by: Lars Kreutzer <lars.kreutzer@tngtech.com>
Signed-off-by: Lars Kreutzer lars.kreutzer@tngtech.com
Summary
Test Plan
Additional Information
The deploy-build-from-pr workflow does indeed seem to require the build-all job.
This change is backwards-breaking