Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): use correct syntax for push event in sudo python tests #14281

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

mpfirrmann
Copy link
Contributor

Signed-off-by: Marco Pfirrmann marco.pfirrmann@tngtech.com

Summary

Amendment to #14227. Using push as a workflow trigger now needs a different syntax. This was missed here.

Test Plan

  • CI runs should now publish to Firebase again.

Additional Information

  • This change is backwards-breaking

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
@mpfirrmann mpfirrmann requested a review from a team as a code owner October 26, 2022 13:33
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 26, 2022
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: ci All updates on CI (Jenkins/CircleCi/Github Action) label Oct 26, 2022
@github-actions
Copy link
Contributor

dp-workflow

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 373be83.

@mpfirrmann mpfirrmann enabled auto-merge (squash) October 26, 2022 13:46
@mpfirrmann mpfirrmann merged commit 23a9000 into magma:master Oct 26, 2022
@mpfirrmann mpfirrmann deleted the pr/event_name branch October 26, 2022 14:16
lucasgonze pushed a commit to lucasgonze/magma that referenced this pull request Feb 29, 2024
…a#14281)

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>

Signed-off-by: Marco Pfirrmann <marco.pfirrmann@tngtech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: ci All updates on CI (Jenkins/CircleCi/Github Action) size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants