fix(agw): Modified code to port UE context to protobuf structure at spgw task #14782

rsarwad · 2023-01-02T08:24:05Z

Summary

agw(fix): Modified code to port UE context to protobuf structure at spgw task

Test Plan

Executed s1ap sanity test suite and unit test cases

… protobuf structure Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

… protobuf structure, S11BearerContext Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…rwad/magma into 11191_spgw_teid_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

github-actions · 2023-01-02T08:24:28Z

✔️ The Semantic PR check ended with status success. See instructions on formatting your commit and pull request titles.

github-actions · 2023-01-02T08:24:53Z

lte/gateway/c/core/oai/test/spgw_task/test_pgw_pco.cpp

-  pco_req.protocol_or_container_ids[0].id =
-      PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING;
+  magma::lte::oai::PcoProtocol* pco_protocol = pco_req.add_pco_protocol();
+  pco_protocol->set_id(PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING);


[misspell] _{reported by reviewdog 🐶}
"SIGNALLING" is a misspelling of "SIGNALING"

github-actions · 2023-01-02T08:26:36Z

lte/gateway/c/core/oai/include/spgw_types.hpp

-typedef magma::proto_map_s<uint32_t,
-                           struct s_plus_p_gw_eps_bearer_context_information_s*>
+// Data: S11BearerContext*
+// TODO (rsarwad): rename S11BearerContext to SpgwSessionContext and also


[cpplint] _{reported by reviewdog 🐶}
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

github-actions · 2023-01-02T08:26:36Z

lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp

+      (proto_ip->pdn_type() == IPv6 || proto_ip->pdn_type() == IPv4_AND_v6)) {
+    inet_pton(AF_INET6, proto_ip->ipv6_addr().c_str(), ipv6);
+  }
+}


[cpplint] _{reported by reviewdog 🐶}
Closing brace should be aligned with beginning of struct in_addr [whitespace/indent] [3]

github-actions · 2023-01-02T08:26:36Z

lte/gateway/c/core/oai/tasks/sgw/spgw_state_converter.cpp

-  if (procedures != nullptr) {
-    pgw_base_proc_t* base_proc = nullptr;
+  proto->set_teid(session_request->teid);
+  proto->set_imsi((char*)session_request->imsi.digit);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<char*>(...) instead [readability/casting] [4]

github-actions · 2023-01-02T08:26:37Z

lte/gateway/c/core/oai/tasks/sgw/spgw_state_converter.cpp

+      break;
+    default:
+      break;
+  };


[cpplint] _{reported by reviewdog 🐶}
You don't need a ; after a } [readability/braces] [4]

github-actions · 2023-01-02T08:26:37Z

lte/gateway/c/core/oai/tasks/sgw_s8/sgw_s8_handlers.cpp

+                                  eps_bearer_ctxt->s_gw_teid_S5_S8_up);
+      }
+
+      // TODO Need to add handling on failing to delete s1-u tunnel rules from


[cpplint] _{reported by reviewdog 🐶}
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

github-actions · 2023-01-02T08:30:27Z

FeG Lint & Test

    2 files 203 suites 40s ⏱️
374 tests 374 ✔️ 0 💤 0 ❌
388 runs 388 ✔️ 0 💤 0 ❌

Results for commit b73040c.

♻️ This comment has been updated with latest results.

github-actions · 2023-01-02T08:50:10Z

DP Lint & Test

14 tests 14 ✔️ 2m 10s ⏱️
  1 suites   0 💤
  1 files   0 ❌

Results for commit b73040c.

♻️ This comment has been updated with latest results.

github-actions · 2023-01-02T08:53:11Z

Orc8r Lint & Test

1 135 tests 1 135 ✔️ 2m 13s ⏱️
  365 suites       0 💤
      7 files       0 ❌

Results for commit b73040c.

♻️ This comment has been updated with latest results.

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

nstng · 2023-01-06T15:22:08Z

@rsarwad, what is the difference to #14810? The changes seem overlapping - what is the plan for merging here?

The Bazel changes look good in general, but it looks to me there are a couple of memory leaks detected in the tests - is this ready-for-review?

rsarwad · 2023-01-06T15:41:02Z

@rsarwad, what is the difference to #14810? The changes seem overlapping - what is the plan for merging here?

The Bazel changes look good in general, but it looks to me there are a couple of memory leaks detected in the tests - is this ready-for-review?

PR #14810 has been branched out from this PR and this PR has been branched out from #14717. But PR 14717 is blocked from getting approvals from magma/approvers-agw .
So currently the diff shows 3 PR changes. To view individual PR changes, I have created PRs in my forked repo, rsarwad#29 and rsarwad#30

Yes with restart test cases, memory leaks are observed. I shall move this PR to draft till memory leaks are fixed

…ad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rdefosse · 2023-01-10T09:28:58Z

@rsarwad

I made a mistake on one of the OAI CI servers while your PR was running. Sorry. It should be OK.

nstng · 2023-01-10T11:45:36Z

//lte/gateway/c/core/oai/test/sgw_s8_task:sgw_dedicated_bearer_test was failing in CI - I recently noticed this one failing and succeeding after restarting the run. This is the second strike - if I see this happening again, then I will mark the test as flaky (will then be executed with a one-out-of-three policy).

Restarted the tests.

rsarwad · 2023-01-10T14:12:02Z

@rsarwad

I made a mistake on one of the OAI CI servers while your PR was running. Sorry. It should be OK.

No problem

nstng · 2023-01-12T10:01:56Z

Bazel and pipelined changes lgtm. Can you please,

argue here why test_spgw_state_converter.cpp was removed
rebase -> in order to re-trigger the oai jenkins tests

I will approve afterwards.

panyogesh · 2023-09-15T18:08:00Z

@VinashakAnkitAman : I guess we can close the PR. Kindly confirm

panyogesh · 2023-09-22T07:11:59Z

@VinashakAnkitAman : We are planning to close it next week. Hope it should be fine.

Sathyaj27 · 2023-10-09T10:09:33Z

Closing this PR

rsarwad added 27 commits November 25, 2022 16:50

Modified code to port s_plus_p_gw_eps_bearer_context_information_t to…

6076675

… protobuf structure Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

504e00d

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Modified code to port s_plus_p_gw_eps_bearer_context_information_t to…

b146a62

… protobuf structure, S11BearerContext Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

aca564e

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Cleaned up the code

cae3d2b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Checking in the updated spgw_state.proto/pb.go file

78e007b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

0d9d9ec

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Fixed the issue found during s1ap integ_tests

8cd5237

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

986ebca

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Removed the file, test_spgw_state_converter.cpp

2cf7c66

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed self comments

492cdd0

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

bc721b4

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed self review comments

2b5e6c7

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

b58948f

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

cf5ec0b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Fixed cpp lint errors

d1cd375

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_teid_ctxt_changes' of https://github.com/rsa…

73d84cb

…rwad/magma into 11191_spgw_teid_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

9b90fdc

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

d127f5c

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

30593e8

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

d7256a0

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

293a884

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

0e1e596

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

fix(agw): Modified code to port UE contexts to protobuf structure

ddf789c

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed self review comments

9a7728b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

f34345e

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_teid_ctxt_changes' of https://github.com/rsa…

8138e29

…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rsarwad requested review from a team January 2, 2023 08:24

github-actions bot reviewed Jan 2, 2023

View reviewed changes

rsarwad changed the title ~~agw(fix): Modified code to port UE context to protobuf structure at spgw task~~ fix(agw): Modified code to port UE context to protobuf structure at spgw task Jan 2, 2023

rsarwad marked this pull request as draft January 2, 2023 08:33

rsarwad added 4 commits January 4, 2023 10:43

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

348dd09

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

4f0a450

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_teid_ctxt_changes' of https://github.com/rsa…

47549ab

…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_teid_ctxt_changes' of https://github.com/rsa…

1ff15c1

…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rsarwad marked this pull request as ready for review January 6, 2023 05:17

Fixed clang errors

b2cc3b0

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rsarwad marked this pull request as draft January 6, 2023 15:41

rsarwad added 2 commits January 9, 2023 17:10

Merge branch '11191_spgw_ue_ctxt_changes' of https://github.com/rsarw…

22d74d6

…ad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Fixed memory leak

c0fbb33

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rsarwad marked this pull request as ready for review January 10, 2023 07:20

Modiifed code to remove warnings that were added in this PR

b73040c

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

nstng mentioned this pull request Jan 12, 2023

fix(agw): Modified code to port spgw's state contexts to protobuf structure #14810

Closed

Sathyaj27 closed this Oct 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(agw): Modified code to port UE context to protobuf structure at spgw task #14782

fix(agw): Modified code to port UE context to protobuf structure at spgw task #14782

rsarwad commented Jan 2, 2023

github-actions bot commented Jan 2, 2023 •

edited

github-actions bot Jan 2, 2023

github-actions bot Jan 2, 2023

github-actions bot Jan 2, 2023

github-actions bot Jan 2, 2023

github-actions bot Jan 2, 2023

github-actions bot Jan 2, 2023

github-actions bot commented Jan 2, 2023 •

edited

github-actions bot commented Jan 2, 2023 •

edited

github-actions bot commented Jan 2, 2023 •

edited

nstng commented Jan 6, 2023

rsarwad commented Jan 6, 2023

rdefosse commented Jan 10, 2023

nstng commented Jan 10, 2023

rsarwad commented Jan 10, 2023

nstng commented Jan 12, 2023

panyogesh commented Sep 15, 2023

panyogesh commented Sep 22, 2023

Sathyaj27 commented Oct 9, 2023

fix(agw): Modified code to port UE context to protobuf structure at spgw task #14782

fix(agw): Modified code to port UE context to protobuf structure at spgw task #14782

Conversation

rsarwad commented Jan 2, 2023

Summary

Test Plan

github-actions bot commented Jan 2, 2023 • edited

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

github-actions bot Jan 2, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 2, 2023 • edited

FeG Lint & Test

github-actions bot commented Jan 2, 2023 • edited

DP Lint & Test

github-actions bot commented Jan 2, 2023 • edited

Orc8r Lint & Test

nstng commented Jan 6, 2023

rsarwad commented Jan 6, 2023

rdefosse commented Jan 10, 2023

nstng commented Jan 10, 2023

rsarwad commented Jan 10, 2023

nstng commented Jan 12, 2023

panyogesh commented Sep 15, 2023

panyogesh commented Sep 22, 2023

Sathyaj27 commented Oct 9, 2023

github-actions bot commented Jan 2, 2023 •

edited

github-actions bot commented Jan 2, 2023 •

edited

github-actions bot commented Jan 2, 2023 •

edited

github-actions bot commented Jan 2, 2023 •

edited