fix(agw): Modified code to port spgw's state contexts to protobuf structure #14810

rsarwad · 2023-01-06T07:03:09Z

Summary

fix(agw): Modified code to port spgw's state contexts to protobuf structure

Test Plan

Executed unit test cases and s1ap sanity test suite

… protobuf structure Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

… protobuf structure, S11BearerContext Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…rwad/magma into 11191_spgw_teid_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…ad/magma into 11191_spgw_state_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

github-actions · 2023-01-06T07:03:28Z

Thanks for opening a PR! 💯

A couple initial guidelines

All commits must be signed off. This is enforced by PR DCO check.
All PR titles must follow the semantic commits format. This is enforced by Semantic PR.

Howto

Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
Checks. All required CI checks must pass before merge.
Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

Contributing Conventions for norms around contributed code

If this is your first Magma PR, also consider reading

Developer Onboarding for onboarding as a new Magma developer
Development Workflow for guidance on your first pull request
CI Checks for points of contact for failing or flaky CI checks
GitHub-to-Slack mappings for Magma maintainers for guidance on how to contact maintainers on Slack

github-actions · 2023-01-06T07:04:02Z

lte/gateway/c/core/oai/test/spgw_task/test_pgw_pco.cpp

-  pco_req.protocol_or_container_ids[0].id =
-      PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING;
+  magma::lte::oai::PcoProtocol* pco_protocol = pco_req.add_pco_protocol();
+  pco_protocol->set_id(PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING);


[misspell] _{reported by reviewdog 🐶}
"SIGNALLING" is a misspelling of "SIGNALING"

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

lte/gateway/c/core/oai/include/spgw_types.hpp

github-actions · 2023-01-06T07:07:40Z

lte/gateway/c/core/oai/tasks/sgw/sgw_handlers.cpp

+      (proto_ip->pdn_type() == IPv6 || proto_ip->pdn_type() == IPv4_AND_v6)) {
+    inet_pton(AF_INET6, proto_ip->ipv6_addr().c_str(), ipv6);
+  }
+}


[cpplint] _{reported by reviewdog 🐶}
Closing brace should be aligned with beginning of struct in_addr [whitespace/indent] [3]

github-actions · 2023-01-06T07:07:40Z

lte/gateway/c/core/oai/tasks/sgw/spgw_state_converter.cpp

+      break;
+    default:
+      break;
+  };


[cpplint] _{reported by reviewdog 🐶}
You don't need a ; after a } [readability/braces] [4]

github-actions · 2023-01-06T07:07:41Z

lte/gateway/c/core/oai/tasks/sgw/spgw_state_manager.cpp

-
-  free_wrapper((void**)&state_cache_p);
+  state_cache_p->Clear();
+  free_cpp_wrapper((void**)&state_cache_p);


[cpplint] _{reported by reviewdog 🐶}
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]

github-actions · 2023-01-06T07:07:41Z

lte/gateway/c/core/oai/tasks/sgw_s8/sgw_s8_handlers.cpp

+                                  eps_bearer_ctxt->s_gw_teid_S5_S8_up);
+      }
+
+      // TODO Need to add handling on failing to delete s1-u tunnel rules from


[cpplint] _{reported by reviewdog 🐶}
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]

github-actions · 2023-01-06T07:15:39Z

FeG Lint & Test

370 tests 369 ✔️ 35s ⏱️
187 suites     0 💤
    1 files     1 ❌

For more details on these failures, see this check.

Results for commit 8f24b24.

♻️ This comment has been updated with latest results.

github-actions · 2023-01-06T07:26:29Z

DP Lint & Test

0 tests 0 ✔️ 0s ⏱️
0 suites 0 💤
0 files 0 ❌

Results for commit 8f24b24.

♻️ This comment has been updated with latest results.

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

github-actions · 2023-01-06T07:41:28Z

Orc8r Lint & Test

551 tests 550 ✔️ 1m 36s ⏱️
204 suites     0 💤
    1 files     1 ❌

For more details on these failures, see this check.

Results for commit 8f24b24.

♻️ This comment has been updated with latest results.

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

LKreutzer

Why does the spgw_state_converter_test need to be removed?

…ad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rsarwad · 2023-01-09T16:54:12Z

Why does the spgw_state_converter_test need to be removed?
The previous code used to convert C structure to proto structure while writing to DB and vice-versa while reading from DB. This PR will have instance of protobuf structure itself, so doesn't involve conversion between C structure to proto structure. Tests within file, spgw_state_converter_test used to validate the conversion logic.

LKreutzer

There are LSan and ASan errors in the SPGW procedures tests:

 //lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_dedicated_bearer_test FAILED in 18.6s
  /var/tmp/bazel/execroot/__main__/bazel-out/k8-fastbuild/testlogs/lte/gateway/c/core/oai/test/spgw_task/spgw_procedures_dedicated_bearer_test/test.log
//lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_session_test     FAILED in 12.5s
  /var/tmp/bazel/execroot/__main__/bazel-out/k8-fastbuild/testlogs/lte/gateway/c/core/oai/test/spgw_task/spgw_procedures_session_test/test.log
//lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_test             FAILED in 15.6s
  /var/tmp/bazel/execroot/__main__/bazel-out/k8-fastbuild/testlogs/lte/gateway/c/core/oai/test/spgw_task/spgw_procedures_test/test.log
//lte/gateway/c/core/oai/test/spgw_task:spgw_procedures_with_injected_state_test FAILED in 3 out of 3 in 21.6s
  Stats over 3 runs: max = 21.6s, min = 21.5s, avg = 21.6s, dev = 0.0s

Please make sure that they are passing with bazel test --config=asan and bazel test --config=production or --config=lsan.

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

…ad/magma into 11191_spgw_state_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

LKreutzer

Bazel changes lgtm

nstng · 2023-01-12T09:57:32Z

Will review after #14782 is merged and PR is rebased.

panyogesh · 2023-09-15T18:09:34Z

@rsarwad : I hope this PR is not required. Can we close it. Idea is to clean up list for upcoming release.

panyogesh · 2023-09-22T07:12:50Z

@rsarwad : We are planning to mark this as closed. I hope it should be fine.

Sathyaj27 · 2023-10-09T10:10:16Z

Closing this PR

rsarwad added 30 commits November 25, 2022 16:50

Modified code to port s_plus_p_gw_eps_bearer_context_information_t to…

6076675

… protobuf structure Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

504e00d

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Modified code to port s_plus_p_gw_eps_bearer_context_information_t to…

b146a62

… protobuf structure, S11BearerContext Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

aca564e

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Cleaned up the code

cae3d2b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Checking in the updated spgw_state.proto/pb.go file

78e007b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

0d9d9ec

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Fixed the issue found during s1ap integ_tests

8cd5237

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

986ebca

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Removed the file, test_spgw_state_converter.cpp

2cf7c66

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed self comments

492cdd0

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

bc721b4

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed self review comments

2b5e6c7

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

b58948f

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

cf5ec0b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Fixed cpp lint errors

d1cd375

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_teid_ctxt_changes' of https://github.com/rsa…

73d84cb

…rwad/magma into 11191_spgw_teid_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

9b90fdc

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

d127f5c

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

30593e8

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed review comment

d7256a0

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

293a884

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

0e1e596

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

fix(agw): Modified code to port UE contexts to protobuf structure

ddf789c

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Addressed self review comments

9a7728b

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Modified code to port spgw_state_t to protobuf structure

60d388d

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

f34345e

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_teid_ctxt_changes' of https://github.com/rsa…

8138e29

…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_ue_ctxt_changes' of https://github.com/rsarw…

3cc1e3c

…ad/magma into 11191_spgw_state_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge remote-tracking branch 'upstream/master' into 11191_spgw_teid_c…

348dd09

…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rsarwad requested review from panyogesh and prabinakpattnaik January 6, 2023 07:03

pull-request-size bot added the size/XXL Denotes a Pull Request that changes 1000+ lines. label Jan 6, 2023

github-actions bot added component: agw Access gateway-related issue component: orc8r Orchestrator-related issue labels Jan 6, 2023

github-actions bot reviewed Jan 6, 2023

View reviewed changes

Corrected the format errors

21c292f

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

github-actions bot reviewed Jan 6, 2023

View reviewed changes

Fixed clang errors

b2cc3b0

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Updating spgw_state.pb.go

3a45189

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

nstng mentioned this pull request Jan 6, 2023

fix(agw): Modified code to port UE context to protobuf structure at spgw task #14782

Closed

LKreutzer reviewed Jan 9, 2023

View reviewed changes

rsarwad added 2 commits January 9, 2023 17:10

Merge branch '11191_spgw_ue_ctxt_changes' of https://github.com/rsarw…

22d74d6

…ad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Fixed memory leak

c0fbb33

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

LKreutzer requested changes Jan 10, 2023

View reviewed changes

rsarwad added 2 commits January 10, 2023 14:24

Modiifed code to remove warnings that were added in this PR

b73040c

Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

Merge branch '11191_spgw_ue_ctxt_changes' of https://github.com/rsarw…

8f24b24

…ad/magma into 11191_spgw_state_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>

rsarwad requested a review from LKreutzer January 10, 2023 09:14

LKreutzer approved these changes Jan 10, 2023

View reviewed changes

nstng mentioned this pull request Jan 12, 2023

fix(agw): Modified code to remove dependency from common state manager for spgw task #14821

Closed

Sathyaj27 closed this Oct 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(agw): Modified code to port spgw's state contexts to protobuf structure #14810

fix(agw): Modified code to port spgw's state contexts to protobuf structure #14810

rsarwad commented Jan 6, 2023

github-actions bot commented Jan 6, 2023

github-actions bot Jan 6, 2023

github-actions bot Jan 6, 2023

github-actions bot Jan 6, 2023

github-actions bot Jan 6, 2023

github-actions bot Jan 6, 2023

github-actions bot commented Jan 6, 2023 •

edited

github-actions bot commented Jan 6, 2023 •

edited

github-actions bot commented Jan 6, 2023 •

edited

LKreutzer left a comment

rsarwad commented Jan 9, 2023

LKreutzer left a comment •

edited

LKreutzer left a comment

nstng commented Jan 12, 2023

panyogesh commented Sep 15, 2023

panyogesh commented Sep 22, 2023

Sathyaj27 commented Oct 9, 2023

fix(agw): Modified code to port spgw's state contexts to protobuf structure #14810

fix(agw): Modified code to port spgw's state contexts to protobuf structure #14810

Conversation

rsarwad commented Jan 6, 2023

Summary

Test Plan

github-actions bot commented Jan 6, 2023

Howto

More info

github-actions bot Jan 6, 2023

Choose a reason for hiding this comment

github-actions bot Jan 6, 2023

Choose a reason for hiding this comment

github-actions bot Jan 6, 2023

Choose a reason for hiding this comment

github-actions bot Jan 6, 2023

Choose a reason for hiding this comment

github-actions bot Jan 6, 2023

Choose a reason for hiding this comment

github-actions bot commented Jan 6, 2023 • edited

FeG Lint & Test

github-actions bot commented Jan 6, 2023 • edited

DP Lint & Test

github-actions bot commented Jan 6, 2023 • edited

Orc8r Lint & Test

LKreutzer left a comment

Choose a reason for hiding this comment

rsarwad commented Jan 9, 2023

LKreutzer left a comment • edited

Choose a reason for hiding this comment

LKreutzer left a comment

Choose a reason for hiding this comment

nstng commented Jan 12, 2023

panyogesh commented Sep 15, 2023

panyogesh commented Sep 22, 2023

Sathyaj27 commented Oct 9, 2023

github-actions bot commented Jan 6, 2023 •

edited

github-actions bot commented Jan 6, 2023 •

edited

github-actions bot commented Jan 6, 2023 •

edited

LKreutzer left a comment •

edited