fix(agw): Modified code to remove dependency from common state manager for spgw task #14821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… protobuf structure Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
… protobuf structure, S11BearerContext Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…rwad/magma into 11191_spgw_teid_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…rwad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ad/magma into 11191_spgw_state_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…txt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ad/magma into 11191_spgw_ue_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…ad/magma into 11191_spgw_state_ctxt_changes Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
…arwad/magma into 11192_spgw_task Signed-off-by: Rashmi <rashmi.sarwad@radisys.com>
pull-request-size
bot
added
the
size/XXL
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
github-actions
bot
added
component: agw
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| pco_req.protocol_or_container_ids[0].id = | ||
| PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING; | ||
| magma::lte::oai::PcoProtocol* pco_protocol = pco_req.add_pco_protocol(); | ||
| pco_protocol->set_id(PCO_CI_IP_ADDRESS_ALLOCATION_VIA_NAS_SIGNALLING); |
There was a problem hiding this comment.
[misspell] reported by reviewdog 🐶
"SIGNALLING" is a misspelling of "SIGNALING"
| typedef magma::proto_map_s<uint32_t, | ||
| struct s_plus_p_gw_eps_bearer_context_information_s*> | ||
| // Data: S11BearerContext* | ||
| // TODO (rsarwad): rename S11BearerContext to SpgwSessionContext and also |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
| (proto_ip->pdn_type() == IPv6 || proto_ip->pdn_type() == IPv4_AND_v6)) { | ||
| inet_pton(AF_INET6, proto_ip->ipv6_addr().c_str(), ipv6); | ||
| } | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Closing brace should be aligned with beginning of struct in_addr [whitespace/indent] [3]
| break; | ||
| default: | ||
| break; | ||
| }; |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
You don't need a ; after a } [readability/braces] [4]
|
|
||
| free_wrapper((void**)&state_cache_p); | ||
| state_cache_p->Clear(); | ||
| free_cpp_wrapper((void**)&state_cache_p); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Using C-style cast. Use reinterpret_cast<void**>(...) instead [readability/casting] [4]
| eps_bearer_ctxt->s_gw_teid_S5_S8_up); | ||
| } | ||
|
|
||
| // TODO Need to add handling on failing to delete s1-u tunnel rules from |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Missing username in TODO; it should look like "// TODO(my_username): Stuff." [readability/todo] [2]
LKreutzer
reviewed
Jan 10, 2023
|
Will review after #14810 is merged and PR is rebased. |
|
@rsarwad : Most of the changes are already integrated. We are planning to go ahead and close the PR. Let us know your inputs. |
|
@rsarwad : We are planning to mark this PR as closed. Hope it should be fine. |
|
Closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(agw): Modified code to remove dependency from common state manager for spgw task
Test Plan
Executed s1ap sanity test suite and unit test cases