-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(amf): Added statistics support for AMF #14976
Merged
panyogesh
merged 6 commits into
magma:master
from
shashidhar-patil:topic/shashidhar/stats
Mar 11, 2024
Merged
fix(amf): Added statistics support for AMF #14976
panyogesh
merged 6 commits into
magma:master
from
shashidhar-patil:topic/shashidhar/stats
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
ad0f691
to
10db69f
Compare
29b35a1
to
7b19063
Compare
lte/gateway/c/core/oai/tasks/amf/include/amf_app_statistics.hpp
Outdated
Show resolved
Hide resolved
3e57da0
to
6d3fd45
Compare
lte/gateway/c/core/oai/lib/message_utils/service303_message_utils.c
Outdated
Show resolved
Hide resolved
lte/gateway/c/core/oai/tasks/service303/service303_mme_stats.cpp
Outdated
Show resolved
Hide resolved
74babcc
to
2483e11
Compare
e608371
to
8aa3879
Compare
90d9650
to
6efc0f3
Compare
panyogesh
approved these changes
Nov 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
20ce54f
to
6ca68d3
Compare
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
6ca68d3
to
48f18e2
Compare
pierre-roussel
pushed a commit
to pierre-roussel/magma
that referenced
this pull request
Mar 22, 2024
* fix(amf): Added statistics support for AMF Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added wrapper functions Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_ue_connected and nb_pdu_session stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_idle stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Addressed internal review comments Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> * fix(amf): Added pb.go file Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> --------- Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
pierre-roussel
pushed a commit
to pierre-roussel/magma
that referenced
this pull request
Mar 29, 2024
* fix(amf): Added statistics support for AMF Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added wrapper functions Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_ue_connected and nb_pdu_session stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_idle stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Addressed internal review comments Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> * fix(amf): Added pb.go file Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> --------- Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>
lucasgonze
pushed a commit
that referenced
this pull request
Apr 16, 2024
* feat: add the rate limit library Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * feat: add all the tested changes Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * refactor: move the rate limit config to the config file Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * refactor: move the middleware in the correct folder Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * test: rate limit middleware Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint warnings Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * feat: add support for env rate limiting env variables Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt to use a default config Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: linting Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix(amf): Added statistics support for AMF (#14976) * fix(amf): Added statistics support for AMF Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added wrapper functions Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_ue_connected and nb_pdu_session stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_idle stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Addressed internal review comments Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> * fix(amf): Added pb.go file Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> --------- Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix(cwg): Add conntrack configuration (#15391) Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai> Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * nit: explicit rate limit response message Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt to fix unit tests in CI Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt fix from GH Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * Readme change to trigger CI Signed-off-by: tmdzk <timothee.dzik@mailchimp.com> --------- Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai> Signed-off-by: tmdzk <timothee.dzik@mailchimp.com> Co-authored-by: Pierre Roussel <roussel.pierre.apb@gmail.com> Co-authored-by: Shashidhar B Patil <89975652+shashidhar-patil@users.noreply.github.com> Co-authored-by: moinuddin1980 <93516965+moinuddin1980@users.noreply.github.com> Co-authored-by: tmdzk <timothee.dzik@mailchimp.com>
brunohcfaria
pushed a commit
to brunohcfaria/magma
that referenced
this pull request
Apr 22, 2024
* feat: add the rate limit library Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * feat: add all the tested changes Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * refactor: move the rate limit config to the config file Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * refactor: move the middleware in the correct folder Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * test: rate limit middleware Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint warnings Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * feat: add support for env rate limiting env variables Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt to use a default config Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: linting Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix(amf): Added statistics support for AMF (magma#14976) * fix(amf): Added statistics support for AMF Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added wrapper functions Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_ue_connected and nb_pdu_session stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_idle stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Addressed internal review comments Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> * fix(amf): Added pb.go file Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> --------- Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix(cwg): Add conntrack configuration (magma#15391) Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai> Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * nit: explicit rate limit response message Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt to fix unit tests in CI Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt fix from GH Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * Readme change to trigger CI Signed-off-by: tmdzk <timothee.dzik@mailchimp.com> --------- Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai> Signed-off-by: tmdzk <timothee.dzik@mailchimp.com> Co-authored-by: Pierre Roussel <roussel.pierre.apb@gmail.com> Co-authored-by: Shashidhar B Patil <89975652+shashidhar-patil@users.noreply.github.com> Co-authored-by: moinuddin1980 <93516965+moinuddin1980@users.noreply.github.com> Co-authored-by: tmdzk <timothee.dzik@mailchimp.com>
brunohcfaria
pushed a commit
to brunohcfaria/magma
that referenced
this pull request
Aug 2, 2024
* feat: add the rate limit library Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * feat: add all the tested changes Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * refactor: move the rate limit config to the config file Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * refactor: move the middleware in the correct folder Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * test: rate limit middleware Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint warnings Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * feat: add support for env rate limiting env variables Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt to use a default config Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: linting Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix(amf): Added statistics support for AMF (magma#14976) * fix(amf): Added statistics support for AMF Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added wrapper functions Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_ue_connected and nb_pdu_session stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Added nb_idle stats Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> * fix(amf): Addressed internal review comments Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> * fix(amf): Added pb.go file Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> --------- Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix(cwg): Add conntrack configuration (magma#15391) Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai> Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * nit: explicit rate limit response message Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt to fix unit tests in CI Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: attempt fix from GH Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * fix: eslint Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> * Readme change to trigger CI Signed-off-by: tmdzk <timothee.dzik@mailchimp.com> --------- Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com> Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai> Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com> Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai> Signed-off-by: tmdzk <timothee.dzik@mailchimp.com> Co-authored-by: Pierre Roussel <roussel.pierre.apb@gmail.com> Co-authored-by: Shashidhar B Patil <89975652+shashidhar-patil@users.noreply.github.com> Co-authored-by: moinuddin1980 <93516965+moinuddin1980@users.noreply.github.com> Co-authored-by: tmdzk <timothee.dzik@mailchimp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: agw
Access gateway-related issue
component: nms
NMS-related issue
component: orc8r
Orchestrator-related issue
size/L
Denotes a Pull Request that changes 100-499 lines.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shashidhar-patil shashidhar.patil@wavelabs.ai
Summary
Added statistics support for AMF.
Stats added:
Snapshot of Grafana Dashboard:
![image](https://user-images.githubusercontent.com/89975652/218696932-8fda860e-65ad-4512-b921-c3dbcbb9282b.png)
Test Plan
Additional Information