Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amf): Added statistics support for AMF #14976

Merged
merged 6 commits into from
Mar 11, 2024

Conversation

shashidhar-patil
Copy link
Contributor

@shashidhar-patil shashidhar-patil commented Feb 8, 2023

Signed-off-by: shashidhar-patil shashidhar.patil@wavelabs.ai

Summary

Added statistics support for AMF.
Stats added:

  • Number of UEs Connected to AMF
  • Number of gNBs Connected to AMF

Snapshot of Grafana Dashboard:
image

Test Plan

  1. Test NMS
    Screenshot from 2023-02-08 17-51-32

Additional Information

  • This change is backwards-breaking

@pull-request-size pull-request-size bot added the size/L Denotes a Pull Request that changes 100-499 lines. label Feb 8, 2023
@shashidhar-patil shashidhar-patil self-assigned this Feb 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added component: agw Access gateway-related issue component: nms NMS-related issue labels Feb 8, 2023
nms/app/components/lte/LteMetrics.tsx Outdated Show resolved Hide resolved
nms/server/grafana/dashboards/Dashboards.ts Outdated Show resolved Hide resolved
nms/server/grafana/dashboards/Dashboards.ts Outdated Show resolved Hide resolved
nms/server/grafana/dashboards/Dashboards.ts Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

NMS Lint & Test

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit 48f18e2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

DP Lint & Test

14 tests   14 ✔️  2m 6s ⏱️
  1 suites    0 💤
  1 files      0

Results for commit 48f18e2.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2023

FeG Lint & Test

    2 files  203 suites   40s ⏱️
374 tests 374 ✔️ 0 💤 0
388 runs  388 ✔️ 0 💤 0

Results for commit 48f18e2.

♻️ This comment has been updated with latest results.

@pull-request-size pull-request-size bot added size/XL Denotes a Pull Request that changes 500-999 lines. and removed size/L Denotes a Pull Request that changes 100-499 lines. labels Oct 13, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2023

Orc8r Lint & Test

1 135 tests   1 135 ✔️  2m 4s ⏱️
   365 suites         0 💤
       7 files           0

Results for commit 48f18e2.

♻️ This comment has been updated with latest results.

@panyogesh panyogesh marked this pull request as ready for review November 6, 2023 06:57
@panyogesh panyogesh requested review from a team as code owners November 6, 2023 06:57
@panyogesh panyogesh requested a review from xbend November 6, 2023 06:57
@pull-request-size pull-request-size bot added size/L Denotes a Pull Request that changes 100-499 lines. and removed size/XL Denotes a Pull Request that changes 500-999 lines. labels Nov 6, 2023
@shashidhar-patil shashidhar-patil force-pushed the topic/shashidhar/stats branch 4 times, most recently from e608371 to 8aa3879 Compare November 6, 2023 09:40
@github-actions github-actions bot added the component: orc8r Orchestrator-related issue label Nov 6, 2023
@shashidhar-patil shashidhar-patil force-pushed the topic/shashidhar/stats branch 2 times, most recently from 90d9650 to 6efc0f3 Compare November 6, 2023 12:24
Copy link
Contributor

@panyogesh panyogesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

shashidhar-patil and others added 6 commits March 11, 2024 15:16
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
@panyogesh panyogesh merged commit 6601481 into magma:master Mar 11, 2024
123 of 124 checks passed
pierre-roussel pushed a commit to pierre-roussel/magma that referenced this pull request Mar 22, 2024
* fix(amf): Added statistics support for AMF

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added wrapper functions

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_ue_connected and nb_pdu_session stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_idle stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Addressed internal review comments

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

* fix(amf): Added pb.go file

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

---------

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
pierre-roussel pushed a commit to pierre-roussel/magma that referenced this pull request Mar 29, 2024
* fix(amf): Added statistics support for AMF

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added wrapper functions

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_ue_connected and nb_pdu_session stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_idle stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Addressed internal review comments

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

* fix(amf): Added pb.go file

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

---------

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>
lucasgonze pushed a commit that referenced this pull request Apr 16, 2024
* feat: add the rate limit library

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* feat: add all the tested changes

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* refactor: move the rate limit config to the config file

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* refactor: move the middleware in the correct folder

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* test: rate limit middleware

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: eslint warnings

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* feat: add support for env rate limiting env variables

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: attempt to use a default config

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: linting

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix(amf): Added statistics support for AMF (#14976)

* fix(amf): Added statistics support for AMF

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added wrapper functions

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_ue_connected and nb_pdu_session stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_idle stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Addressed internal review comments

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

* fix(amf): Added pb.go file

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

---------

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix(cwg): Add conntrack configuration (#15391)

Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai>
Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* nit: explicit rate limit response message

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: eslint

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: attempt to fix unit tests in CI

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: attempt fix from GH

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: eslint

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* Readme change to trigger CI

Signed-off-by: tmdzk <timothee.dzik@mailchimp.com>

---------

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai>
Signed-off-by: tmdzk <timothee.dzik@mailchimp.com>
Co-authored-by: Pierre Roussel <roussel.pierre.apb@gmail.com>
Co-authored-by: Shashidhar B Patil <89975652+shashidhar-patil@users.noreply.github.com>
Co-authored-by: moinuddin1980 <93516965+moinuddin1980@users.noreply.github.com>
Co-authored-by: tmdzk <timothee.dzik@mailchimp.com>
brunohcfaria pushed a commit to brunohcfaria/magma that referenced this pull request Apr 22, 2024
* feat: add the rate limit library

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* feat: add all the tested changes

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* refactor: move the rate limit config to the config file

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* refactor: move the middleware in the correct folder

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* test: rate limit middleware

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: eslint warnings

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* feat: add support for env rate limiting env variables

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: attempt to use a default config

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: linting

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix(amf): Added statistics support for AMF (magma#14976)

* fix(amf): Added statistics support for AMF

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added wrapper functions

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_ue_connected and nb_pdu_session stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Added nb_idle stats

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>

* fix(amf): Addressed internal review comments

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

* fix(amf): Added pb.go file

Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>

---------

Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix(cwg): Add conntrack configuration (magma#15391)

Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai>
Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* nit: explicit rate limit response message

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: eslint

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: attempt to fix unit tests in CI

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: attempt fix from GH

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* fix: eslint

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>

* Readme change to trigger CI

Signed-off-by: tmdzk <timothee.dzik@mailchimp.com>

---------

Signed-off-by: Pierre Roussel <roussel.pierre.apb@gmail.com>
Signed-off-by: shashidhar-patil <shashidhar.patil@wavelabs.ai>
Signed-off-by: shashidhar-patil <shashidhar.patil@veltris.com>
Signed-off-by: moinuddin khan <moinuddin.khan@wavelabs.ai>
Signed-off-by: tmdzk <timothee.dzik@mailchimp.com>
Co-authored-by: Pierre Roussel <roussel.pierre.apb@gmail.com>
Co-authored-by: Shashidhar B Patil <89975652+shashidhar-patil@users.noreply.github.com>
Co-authored-by: moinuddin1980 <93516965+moinuddin1980@users.noreply.github.com>
Co-authored-by: tmdzk <timothee.dzik@mailchimp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue component: nms NMS-related issue component: orc8r Orchestrator-related issue size/L Denotes a Pull Request that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants