feat(pipelined): Support extended bitrates for 5g #15171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mehul-jindal-wavelabs <mehul.jindal@wavelabs.ai>
|
Thanks for opening a PR! 💯
Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
Logs
|
Logs
$MAGMA_ROOT/bazel/scripts/run_integ_tests.sh
.
.
.
SUMMARY: 163/167 tests were successful.
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_activation_reject: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_security_algo_eea2_eia2: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_standalone_act_dflt_ber_ctxt_rej: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_x2_handover_ping_pong: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_mobile_reachability_tmr_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_eps_bearer_context_status_ded_bearer_deact: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_restricted_plmn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_security_algo_eea1_eia1: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_bearer_deactivation_invalid_imsi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_outoforder_attach_complete_ICSR: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_no_ueContext_release_comp: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_act_dflt_ber_ctxt_rej: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_maxbearers_twopdns: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_paging_after_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_enb_complete_reset: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_s1setup_failure_incorrect_plmn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_multiple_secondary_pdn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_non_nat_dhcp_multi_ue: FAILED
//lte/gateway/python/integ_tests/s1aptests:test_eps_bearer_context_status_def_bearer_deact: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_after_ue_context_release: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_x2_handover: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_sctp_abort_after_smc: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_non_nat_dhcp: FAILED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_static_ip: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_no_disconnect: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_sctpd_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_ics_timer_expiry_ue_unregistered: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_asr: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_s1setup_failure_incorrect_tac: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_multi_enb_multi_ue_diff_plmn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_eps_bearer_context_status_multiple_ded_bearer_deact: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_service_req_ul_udp_data_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_multi_enb_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_with_dedicated_bearer_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_nw_triggered_delete_last_pdn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_dedicated_bearer_activation_idle_mode_paging_timer_expiry: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_multi_ue_looped: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_bearer_deactivation_invalid_lbi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_multi_enb_sctp_shutdown: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service_ue_radio_capability: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_tau_mixed_partial_lists: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_flaky_retry_success: FAILED
//lte/gateway/python/integ_tests/s1aptests:test_no_attach_complete: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_secondary_pdn_reject_unknown_pdn_type: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ul_udp_data_with_pipelined_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ul_tcp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_he_policy: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_dl_tcp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_s1setup_success_secondary_plmn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_nas_non_delivery_for_auth: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service_with_multi_pdns_and_bearers_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_multi_enb_complete_reset: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_with_dedicated_bearer: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_nw_triggered_delete_secondary_pdn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_s1_handover: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_mobilityd_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_sctp_shutdown_after_smc: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_disconnect_default_pdn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_ps_service_not_available: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_missing_imsi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_sctp_shutdown_after_auth_req: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_imei_restriction_smc: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ue_ctxt_release_cmp_delay: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_resync: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ul_udp_data_with_multiple_service_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_nw_initiated_detach_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_setsessionrules_tcp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_security_algo_eea0_eia0: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_duplicate_nas_resp_messages: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ul_udp_data_with_mobilityd_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ul_udp_data_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_ICS_Failure: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_tau_periodic_active: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_multiple_ip_blocks_mobilityd_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_auth_failure: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_multiple_dedicated: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_sctp_shutdown_after_multi_ue_attach: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_without_ips_available: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_combined_eps_imsi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_no_security_mode_complete: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_gateway_metrics_attach_detach: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_pcscf_address: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_nw_initiated_detach_fail: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_no_auth_response: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_tau_ta_updating_reject: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_idle_mode_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_dedicated_bearer_activation_idle_mode: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_with_dedicated_bearer_looped: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_sctp_abort_after_auth_req: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_ipv4v6_paging_with_dedicated_bearer: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_rar_tcp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_dedicated_bearer_activation_idle_mode_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_guti_attach_with_zero_mtmsi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_multi_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_looped: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_bearer_deactivation_invalid_ebi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_bearer_activation_invalid_imsi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service_with_multi_pdns_and_bearers_failure: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_with_dedicated_bearer_deactivate: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_non_nat_dhcp_multi_ue_looped: FAILED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_activation_timer_expiry: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ul_udp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_security_mode_reject: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_ics_timer_expiry_ue_registered: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_deactivation_timer_expiry: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_esm_information_wrong_apn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_multi_enb_partial_reset: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_enb_rlf_initial_ue_msg: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_rar_tcp_he: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_emergency: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_attach_ul_tcp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_service_info: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service_with_multi_pdns_and_bearers_mt_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ul_udp_data_with_sessiond_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_disconnect_dedicated_bearer: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_looped: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_qci_0: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_3485_timer_for_dedicated_bearer_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_secondary_pdn_reject_multiple_sessions_not_allowed_per_apn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_mobile_reachability_timer_expiry: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_no_initial_context_resp: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_looped: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_3485_timer_for_default_bearer_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_standalone_pdn_conn_req: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_ipv4v6_pdn_type: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_ics_timer_expiry_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_imei_restriction_no_imeisv_in_smc: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service_with_multi_pdns_and_bearers_looped: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_multi_enb_multi_ue_diff_enbtype: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_dl_udp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_invalid_apn: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_tau_periodic_inactive: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_sctp_abort_after_identity_req: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_enb_partial_reset_con_dereg: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_identity_timer_3470_expiry: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_enb_partial_reset: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_via_guti: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_tau_ta_updating: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_duplicate_attach: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_different_enb_s1ap_id_same_ue: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_imei_restriction_wildcard_snr: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_service: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_dedicated_bearer_activation_invalid_lbi: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_implicit_detach_timer_expiry: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_ipv6_paging_with_dedicated_bearer: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_with_ovs: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_emm_status: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_services_are_running: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_with_pcscf_address: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_implicit_detach_timer_with_mme_restart: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_esm_information: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_secondary_pdn_disconnect_invalid_bearer: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_tau_ta_updating_connected_mode: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_service_with_multi_pdns_and_bearers: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_nas_non_delivery_for_smc: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_nas_non_delivery_for_identity_req: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_multiple_rar_tcp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_attach_detach_attach_dl_tcp_data: PASSED
//lte/gateway/python/integ_tests/s1aptests:test_sctp_shutdown_after_identity_req: PASSED
|
| @@ -141,7 +140,7 @@ def del_filter(self, iface: str, mark: str, qid: str, proto: int = PROTOCOL) -> | |||
|
|
|||
| def create( | |||
| self, iface: str, qid: str, max_bw: int, rate=None, | |||
| parent_qid: Optional[str] = None, proto=PROTOCOL, | |||
| parent_qid: str = None, proto=PROTOCOL, | |||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Incompatible default for argument "parent_qid" (default has type "None", argument has type "str") [assignment]
| @@ -141,7 +140,7 @@ | |||
|
|
|||
| def create( | |||
| self, iface: str, qid: str, max_bw: int, rate=None, | |||
| parent_qid: Optional[str] = None, proto=PROTOCOL, | |||
| parent_qid: str = None, proto=PROTOCOL, | |||
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
PEP 484 prohibits implicit Optional. Accordingly, mypy has changed its default to no_implicit_optional=True
| @@ -141,7 +140,7 @@ | |||
|
|
|||
| def create( | |||
| self, iface: str, qid: str, max_bw: int, rate=None, | |||
| parent_qid: Optional[str] = None, proto=PROTOCOL, | |||
| parent_qid: str = None, proto=PROTOCOL, | |||
There was a problem hiding this comment.
📝 [mypy] reported by reviewdog 🐶
Use https://github.com/hauntsaninja/no_implicit_optional to automatically upgrade your codebase
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Weird number of spaces at line-start. Are you using a 2-space indent? [whitespace/indent] [3]
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
mehul-jindal
force-pushed
the
bitrate_units
branch
from
dc09fdc
to
c594329
Compare
| break; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
mehul-jindal
force-pushed
the
bitrate_units
branch
from
c594329
to
fb1990c
Compare
Signed-off-by: mehul-jindal-wavelabs <mehul.jindal@wavelabs.ai>
mehul-jindal
force-pushed
the
bitrate_units
branch
from
fb1990c
to
5728413
Compare
lucasgonze
pushed a commit
to lucasgonze/magma
that referenced
this pull request
Feb 29, 2024
* feat(pipelined): Support extended bitrates for 5g Signed-off-by: mehul-jindal-wavelabs <mehul.jindal@wavelabs.ai> * address lint errors Signed-off-by: mehul-jindal-wavelabs <mehul.jindal@wavelabs.ai> --------- Signed-off-by: mehul-jindal-wavelabs <mehul.jindal@wavelabs.ai> Co-authored-by: prabinakpattnaik <69528542+prabinakpattnaik@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In order to support extended bit rates for 5g (feature defined here #5676), we are introducing a flag on Qos to set units of the bitrates (either bps or kbps)
Pipelined needs to check the value of units to apply the right value for Qos
Pipelined will receive a new field called
br_unitsonapn_ambr(as you can see below). That field is the multiplier for the values.Test Plan
Tested with sessiond stub CLI
magma/lte/gateway/python/scripts/smf_upf_integration_cli.pyAdditional Information
Refer subsequent comments for logs