Added code to get imsi64 from timer handlers #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rashmi <rashmi.sarwad@radisys.com>
ssanadhya
requested changes
Aug 11, 2020
There was a problem hiding this comment.
Please clean-up this PR to remove the committed code from @themarwhal .
rsarwad
force-pushed
the
rsarwad_new_pr_get_imsi_from_timer_handlers
branch
from
a6f7d3c
to
6b1a7f4
Compare
Signed-off-by: rashmi <rashmi.sarwad@radisys.com>
rsarwad
force-pushed
the
rsarwad_new_pr_get_imsi_from_timer_handlers
branch
from
dcddd7c
to
6b1a7f4
Compare
This was referenced Aug 14, 2020
ssanadhya
reviewed
Aug 14, 2020
| @@ -802,7 +805,7 @@ static int _emm_tracking_area_update_accept( | |||
|
|
|||
| OAILOG_INFO( | |||
| LOG_NAS_EMM, | |||
| "EMM-PROC - Timer T3450 (%ld) expires in %ld" | |||
| "EMM-PROC - Timer T3450 (%ld) expires in %d" | |||
There was a problem hiding this comment.
As timer.sec has changed from "long" to "uint32_t", the printf specifier would change from %ld to %lu .
ssanadhya
reviewed
Aug 14, 2020
| @@ -1953,8 +1956,7 @@ static int _emm_attach_accept_retx(emm_context_t* emm_context) { | |||
| attach_proc->ue_id); | |||
| OAILOG_DEBUG( | |||
| LOG_NAS_EMM, | |||
| "UE " MME_UE_S1AP_ID_FMT | |||
| " Timer T3450 (%ld) expires in %ld seconds\n", | |||
| "UE " MME_UE_S1AP_ID_FMT " Timer T3450 (%ld) expires in %d seconds\n", | |||
There was a problem hiding this comment.
Use %lu instead of %d for uint32_t
…t_imsi_from_timer_handlers
Signed-off-by: rashmi <rashmi.sarwad@radisys.com>
ssanadhya
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue #1 : While testing the Implicit detach timer with MME restart observed that UE contexts were not updated to redis DB. Because on timer expiry, imsi64 was neither received from timer module nor got from the handler function. So imsi64 was set to "INVALID_IMSI64". Only for valid imsi64 values, UE contexts are updated to DB.
Approach followed to address above issue:
Modified code to get imsi64 for all timers on expiry.
Issue #2: The prototype of timer start function is int timer_setup(
uint32_t interval_sec, uint32_t interval_us, task_id_t task_id,
int32_t instance, timer_type_t type, void* timer_arg, size_t arg_size,
long* timer_id)
Which expects seconds and micro-seconds to be of datatype uint32_t, but for most timers while calling timer_setup, seconds and micro-seconds were defined as long
Modified the datatype of duration of all timers to to match prototype of timer start function.
Test Plan:
Executed s1ap tester sanity test suite