Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cwf] analytics safety checks and logging #2624

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

Scott8440
Copy link
Contributor

Signed-off-by: Scott8440 scott8440@gmail.com

Summary

  • Add checks to ensure labels returned from prometheus match the expected labels in the gauge which is used to store that result's values. This prevents panics and service restarts
  • Add logging to make it more clear what's going on in the service

Test Plan

  • Unit tests
  • Run service locally and see all calculations are being performed + logging

Signed-off-by: Scott8440 <scott8440@gmail.com>
@xjtian xjtian merged commit 6222c38 into magma:master Sep 3, 2020
@Scott8440 Scott8440 deleted the analyticsFixes branch September 8, 2020 17:00
ulaskozat pushed a commit to ulaskozat/magma that referenced this pull request Sep 16, 2020
Signed-off-by: Scott8440 <scott8440@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants