-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add Resources folder with PCAPs and Useful Links sections #6778
Conversation
Thanks for opening a PR! 💯 HowtoReviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it. Checks. All required CI checks must pass before merge. Merge. Once approved and passing all CI checks, use the More infoAll commits must be signed off. This is enforced by the Please take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great idea, we are always searching for pcaps & protocol examples for unit tests & implementation specifics.
docs/readmes/resources/pcap.md
Outdated
|
||
# PCAP collection | ||
|
||
This is a collection of `.pcap` files that can be open using [Wireshark](https://www.wireshark.org/). Some of those PCAP collect data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of those PCAP collect data
seems like an incomplete sentence :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch! it was hidden on my IDE far far in the right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the additions, thanks @uri200! Two requests
- We're trying to keep the number of top-level sections as small as possible. For the pcaps etc, please put those into a subsection under Technical Reference. For the links, please put them somewhere in the intro/getting started section
- Is the inline HTML necessary in the Markdown files? e.g. the
<br />
Hey @hcgatewood, initially I had it in Technical Resources, then I moved it to How Tos. After discussing with @talkhasib we thought it didn't belong to any of the categories displayed. I am fine with any location. Should we move For the |
So the idea is to separate "Usage" as basic information for operators, and "Technical Reference" as more in-depth information for SIs, VARs, and devs. So I would say this info would fit best under For the Markdown -- just do something like this, maybe even as a list |
Techincal Reference/General sounds good to me if @talkhasib doesn't have any problem with it. |
a231485
to
ed66801
Compare
under Reference/General sounds good |
Done, added it to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding. Couple small comments before merge
docs/readmes/resources/pcap.md
Outdated
hide_title: true | ||
--- | ||
|
||
*Last Updated: 4/20/2021* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both files: these timestamps aren't necessary / won't get updated when people make changes. Docusaurus has a feature to add these automatically, so look into that if you're interested in providing this affordance
docs/docusaurus/sidebars.json
Outdated
"type": "subcategory", | ||
"label": "General", | ||
"ids": [ | ||
"resources/pcap", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For both ids: prefix them both with either dev_
or ref_
for namespacing purposes
|
||
This is a list of links that may be useful to understand Magma | ||
|
||
- [Netmanias](https://www.netmanias.com/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add some minor info about what these links contain
Signed-off-by: Oriol Batalla <obatalla@fb.com>
Codecov Report
@@ Coverage Diff @@
## master #6778 +/- ##
==========================================
- Coverage 64.45% 61.97% -2.48%
==========================================
Files 671 521 -150
Lines 46527 35696 -10831
Branches 1318 0 -1318
==========================================
- Hits 29990 22124 -7866
+ Misses 13120 10473 -2647
+ Partials 3417 3099 -318
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Oriol Batalla obatalla@fb.com
Summary
Add a new section called
Resources
where to drop useful links, files, or information for Magma users.Added PCAPs with GX/GY and inbound roaming examples
Test Plan
run docusaurus locally
Additional Information