Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(agw): gtp-br0 interface definition. #9355

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

pshelar
Copy link
Contributor

@pshelar pshelar commented Sep 29, 2021

following patch fixes error seen on latest OVS:

root@phy-u3:~# ifup gtp_br0
RTNETLINK answers: File exists
ovs-vsctl: type=: argument does not end in "=" followed by a value.
net.ipv4.ip_forward = 1

Signed-off-by: Pravin B Shelar pbshelar@fb.com

Summary

Test Plan

Additional Information

  • This change is backwards-breaking

following patch fixes error seen on latest OVS:
```
root@phy-u3:~# ifup gtp_br0
RTNETLINK answers: File exists
ovs-vsctl: type=: argument does not end in "=" followed by a value.
net.ipv4.ip_forward = 1
```
Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
@pshelar pshelar requested a review from a team as a code owner September 29, 2021 19:18
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines. label Sep 29, 2021
@pshelar pshelar requested a review from koolzz September 29, 2021 19:18
@github-actions
Copy link
Contributor

Thanks for opening a PR! 💯

A couple initial guidelines

Howto

  • Reviews. The "Reviewers" listed for this PR are the Magma maintainers who will shepherd it.
  • Checks. All required CI checks must pass before merge.
  • Merge. Once approved and passing CI checks, use the ready2merge label to indicate the maintainers can merge your PR.

More info

Please take a moment to read through the Magma project's

If this is your first Magma PR, also consider reading

@github-actions github-actions bot added the component: agw Access gateway-related issue label Sep 29, 2021
@github-actions
Copy link
Contributor

cloud-workflow

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0

Results for commit 1205bdf.

@github-actions
Copy link
Contributor

feg-workflow

    2 files  145 suites   30s ⏱️
338 tests 338 ✔️ 0 💤 0
352 runs  352 ✔️ 0 💤 0

Results for commit 1205bdf.

@pshelar pshelar merged commit b1aca73 into magma:master Sep 29, 2021
pshelar added a commit to pshelar/magma that referenced this pull request Sep 29, 2021
following patch fixes error seen on latest OVS:
```
root@phy-u3:~# ifup gtp_br0
RTNETLINK answers: File exists
ovs-vsctl: type=: argument does not end in "=" followed by a value.
net.ipv4.ip_forward = 1
```
Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
pshelar added a commit that referenced this pull request Sep 29, 2021
following patch fixes error seen on latest OVS:
```
root@phy-u3:~# ifup gtp_br0
RTNETLINK answers: File exists
ovs-vsctl: type=: argument does not end in "=" followed by a value.
net.ipv4.ip_forward = 1
```
Signed-off-by: Pravin B Shelar <pbshelar@fb.com>
@github-actions
Copy link
Contributor

agw-workflow

    2 files      2 suites   3m 21s ⏱️
471 tests 462 ✔️ 9 💤 0
472 runs  463 ✔️ 9 💤 0

Results for commit 1205bdf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: agw Access gateway-related issue size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants