fix(agw): Cherry-pick: Compensate for eNB firmware param inversion (#9967) #9982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(agw): Compensate for eNB firmware param inversion A regression was introduced into the firmware build for Sercomm where the flag for cell reserved was inverted. Compensate for that by setting the cell reserved bit to be True on initial connect. At a later point when we have a software version where the issue is fixed we can add this as a conditional check. Signed-off-by: Amar Padmanabhan <amar@freedomfi.com> * fix(agw): Update tests for cell reserved Update expectations to account for calls to Cell Reserved Also fixes an issue where in place sort was wrongly used in assertEqual Signed-off-by: Amar Padmanabhan <amar@freedomfi.com> Co-authored-by: Amar Padmanabhan <amar@freedomfi.com>
|
Thanks for opening a PR! 💯 Please note that all commits must be signed off. This is enforced by the Howto
More infoPlease take a moment to read through the Magma project's
If this is your first Magma PR, also consider reading
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix(agw): Compensate for eNB firmware param inversion
A regression was introduced into the firmware build for Sercomm where
the flag for cell reserved was inverted. Compensate for that by
setting the cell reserved bit to be True on initial connect.
At a later point when we have a software version where the issue is fixed
we can add this as a conditional check.
Signed-off-by: Amar Padmanabhan amar@freedomfi.com
fix(agw): Update tests for cell reserved
Update expectations to account for calls to Cell Reserved
Also fixes an issue where in place sort was wrongly used in assertEqual
Signed-off-by: Amar Padmanabhan amar@freedomfi.com
Co-authored-by: Amar Padmanabhan amar@freedomfi.com
Test Plan
make test
Additional Information