Skip to content

Relax expected timestamp test to a 48hr range for zipfile entries #13

merged 1 commit into from Feb 27, 2014

2 participants

arbscht commented Feb 27, 2014

The last modified timestamp for zip/jar entries is TZ-lossy and may not serialize/deserialize across timezones to exactly the same unixtime. The unit test is only concerned with finding a plausible timestamp, not a perfectly accurate one. The +24hr/-24hr range is wide enough to cover all timezones.

magnars commented Feb 27, 2014

Excellent. Thank you!

@magnars magnars merged commit 9d070cc into magnars:master Feb 27, 2014

1 check passed

Details default The Travis CI build passed
@arbscht arbscht referenced this pull request Feb 27, 2014

Failing last-modified test? #11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.