Relax expected timestamp test to a 48hr range for zipfile entries #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. Thank you! |
magnars
added a commit
that referenced
this pull request
Feb 27, 2014
…-timezones Relax expected timestamp test to a 48hr range for zipfile entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last modified timestamp for zip/jar entries is TZ-lossy and may not serialize/deserialize across timezones to exactly the same unixtime. The unit test is only concerned with finding a plausible timestamp, not a perfectly accurate one. The +24hr/-24hr range is wide enough to cover all timezones.