Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucs-normalize takes a bit time to load #77

Closed
yashi opened this issue Sep 22, 2015 · 1 comment
Closed

ucs-normalize takes a bit time to load #77

yashi opened this issue Sep 22, 2015 · 1 comment

Comments

@yashi
Copy link

yashi commented Sep 22, 2015

#58 fixes a real bug which is very nice, however, the fix requires ucs-normalize unconditionally. This adds 71 ms and doubles Emacs load time at least in my set up.

Is it possible to defer loading of ucs-normalize?
I'm not sure why it takes that long. Maybe it's the ucs-normalize we need to fix. Does anyone has a clue?
Or am I asking too much for too little gain?

Here is an output of benchmark-init-el.

╼►[benchmark-init/root nil 139ms]
  ├─[default load 5ms]
  ├─[avy require 3ms]
  ├─[migemo require 4ms]
  ├─[imenu require 5ms]
  ├─[ring require 4ms]
  ├─[s require 4ms]
  │ ╰─[ucs-normalize require 71ms]
  ├─[popwin require 4ms]
  ├─[dash require 6ms]
  ├─[thingatpt require 4ms]
  ├─[ido-ubiquitous require 9ms]
  │ ╰─[ido-completing-read+ require 3ms]
  ├─[ido-vertical-mode require 2ms]
  │ ╰─[ido require 11ms]
  ╰─[bind-key require 3ms]
@hmelman
Copy link

hmelman commented Oct 18, 2015

Maybe move the require inside of s-reverse so not everyone pays the penalty?

basil-conto added a commit to basil-conto/s.el that referenced this issue Mar 24, 2017
Defer requiring ucs-normalize until variable
ucs-normalize-combining-chars is used in function s-reverse. This
should result in s.el loading faster.

Addresses issue magnars#77
basil-conto added a commit to basil-conto/s.el that referenced this issue Apr 8, 2017
Defer requiring ucs-normalize until variable
ucs-normalize-combining-chars is used in function s-reverse. This
should result in s.el loading faster.

Addresses issue magnars#77
basil-conto added a commit to basil-conto/s.el that referenced this issue Apr 28, 2017
Defer requiring ucs-normalize until variable
ucs-normalize-combining-chars is used in function s-reverse. This
should result in s.el loading faster.

Addresses issue magnars#77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants