Fix resty client TLS client config setting error: current transport is not an *http.Transport instance
#72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #58 is not correctly done, for the
oauth2
clients, which are built when the security config is set tooauth2
.In the debug log, you'll notice error
current transport is not an *http.Transport instance
being raised fromresty
, which actually is from:The reason is that the
oauth2
client'sTransport
field is not a*http.Transport
, but*oauth2.Transport
.To fix this, when building the client, we initially create a default http client, which is of type
http.Client
, and move the tls config setting and the jar setting up right after this client is built. Then based on the security setting, we further create aresty.Client
wrapping this default client, or wrapping anoauth2
client, which in turns wrapping this default client.