restful_resource & restful_operation - Remove query for poll_xxx block
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `query` from either poll url_locator or inherit from the original request if url_locator not specified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
queryfrompoll_xxxblock forrestful_resourceandrestful_operation.During polling, the actual query used is either from the polling
url_locator(as the polling URL is expected to contain the complete URL, including the query needed), or inherit from the originating request ifurl_locatornot specified.Previously, we were intentionally removing the query part from the polling URL, and inherit from the originating request, which can be overwritten by the
poll_xxx.query. This causes issues like #69.Fix #69.