Inms #190
Inms #190
Conversation
There was a problem hiding this comment.
In principle the changes seem fine but as a set is expanded, can you confirm if the default starting script makes sure that the run is compiled correctly and works as expected?
Also might be a good idea if @bodirsky can have a look.
I just checked again: It does compile correctly. |
There was a problem hiding this comment.
The changed set also means that f50_snupeand f50_nue_pasture would get some additional info. Both of these are regional data. I see that the input file vector has been updated in the user specific starting script but not in default.cfg.
A default run using a default config would mean that f50_snupeand f50_nue_pasture would still be downloaded from rev4.44_h12_magpie.tgz which won't contain data for the expanded set scen_neff50 of this PR.
In principle this is okay as GAMS can handle data from a file which contains less indexes than the defined set but it'll be good if you can update the revision number in default.cfg as well.
@tscheypidi do you want to give it a go as well?
I made a new preprocessing with h12 setting (rev4.47) and tested it. Runs without error. Also included it in the default.cfg now. |
Added new inputs: nitrogen efficiency scenario according to Zhang and updated INMS2 start script