Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix v35_secdforest_expansion in 35_other land module. #227

Merged
merged 2 commits into from
Oct 23, 2020
Merged

Bugfix v35_secdforest_expansion in 35_other land module. #227

merged 2 commits into from
Oct 23, 2020

Conversation

flohump
Copy link
Contributor

@flohump flohump commented Oct 23, 2020

Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):

Purpose of this PR

  • Bugfix v35_secdforest_expansion in 35_other land module.

Performance loss/gain from current default behavior

Type of change

  • Bug fix (Change which fixes an issue).
  • New feature (Change which adds functionality).
  • Minor change (Change which does not modify core model code i.e., in /modules).
  • Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

  • gams main.gms for some time steps.

Checklist:

  • Self-review of my own code.
  • Added changes to CHANGELOG.md
  • No hard coded numbers and cluster/country/region names.
  • The code doesn't contain declared but unused parameters or variables.
  • In-code comments added including documentation comments.
  • Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
  • Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

  • Notes

abhimishr
abhimishr approved these changes Oct 23, 2020
View reviewed changes
Copy link
Member

@abhimishr abhimishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@abhimishr abhimishr merged commit 4fbfcec into magpiemodel:develop Oct 23, 2020
@flohump flohump deleted the f_bugfix_secdf branch October 23, 2020 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhimishr abhimishr abhimishr approved these changes

@tscheypidi tscheypidi Awaiting requested review from tscheypidi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flohump @abhimishr