Incorporating agricultural residue burning emissions

[mscrawford]

Purpose of this PR

Incorporate the emissions calculations from agricultural residue burning (N2O, NO2). Changes to 18_residues and 51_nitrogen.

Performance loss/gain from current default behavior

~ 7% performance loss

Type of change

• Bug fix (Change which fixes an issue).
• New feature (Change which adds functionality).
• Minor change (Change which does not modify core model code i.e., in /modules).
• Major change (fix or feature that would change current model behavior).

How Has This Been Tested?

The new calculations are present in the .GDX. The following plot shows the correspondence between MAgPIE's calculations and the historical FAO data for N2O.

Additions or Changes to default configuration (default.cfg):

One new file was added, incorporating the emissions factors taken from the IPCC 2019 revision, f51_ef_resid_burn.cs4

Checklist:

• Self-review of my own code.
• Compilation check (model starts without compilation errors).
• Added changes to CHANGELOG.md
• No hard coded numbers and cluster/country/region names.
• The code doesn't contain declared but unused parameters or variables.
• In-code comments added including documentation comments.
• Compiled and checked resulting documentation with goxygen::goxygen() for the new/updated parts.
• Changes to magpie4 R library for post processing of model output (ideally backward compatible).

Special comments/warnings

The additions don't add anything to the optimization, but do increase the total number of calculations.

[tscheypidi]

As you have introduced a new interface, please update the module contracts of the corresponding modules. You find the contracts as part of the goxygen documentation in the module.gms files of the corresponding modules.

The module contract should describe what the purpose of the module is, what outputs it is promising to provide and what inputs it is expecting to get in order to compute the outputs.

In addition I saw that in one off-realization you just set the value of that new interface to zero. The description of that realization should make very clear what scenario this module is representing. In your case, if no residue burning is happening, what is happening instead?

[mscrawford]

I have now amended the module contracts for both 18_residues and 51_nitrogen to be more specific.

[mscrawford]

I've now amended the documentation to better fit Jan's specifications.

[tscheypidi]

looks good

[tscheypidi]

@mscrawford what is the status here? Still needs @bodirsky to review, right? Should probably happen rather soon as PR are currently piling up

[mscrawford]

Yes, I am waiting for Benni on this one!

…

On Mon, Apr 26, 2021 at 21:24 Jan Dietrich ***@***.***> wrote: @mscrawford <https://github.com/mscrawford> what is the status here? Still needs @bodirsky <https://github.com/bodirsky> to review, right? Should probably happen rather soon as PR are currently piling up — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#268 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXWSGR4NCGZWXDGVKMZ3I3TKW4YFANCNFSM42SZQ3MA> .

[bodirsky]

all fine!