-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix SCP "mixed" scenario + "kfo_rd" set added to config file #270
Conversation
@@ -72,6 +72,9 @@ sets | |||
VIR,VNM,VUT,WLF,WSM,YEM,ZAF,ZMB,ZWE / | |||
; | |||
|
|||
$onMultiR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need $onMultiR here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because the set kfo_rd needs to be defined in sets.gms (some declarations depend on kfo_rd) and then overwritten in input.gms.
@bodirsky @weindl @tscheypidi I need your feedback on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, but could you please pull the recent version of develop into your branch as there was recently another PR accepted (I don't see these changes in your diff view at the moment for some reason)
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few tiny changes (see comments above)
Please fill following information
(Add additional info if you think its important and not covered by this Pull Request (PR)):
Purpose of this PR
Performance loss/gain from current default behavior
shinyresults::appResults()
and annotate accordingly.Both scenarios reflecting a default model run (based on default.cfg)
SCP34 = current develop
SCP35 = f_SCP2
The run time is almost the same (slightly faster).
Type of change
How Has This Been Tested?
Additions or Changes to default configuration (default.cfg):
Additions are the introduction of new model components in default config
Changes are deletion or updates to the existing model components in default config
Checklist:
CHANGELOG.md
goxygen::goxygen()
for the new/updated parts.magpie4
R library for post processing of model output (ideally backward compatible).Special comments/warnings