Add biomass demand for bioplastics in 62_material

[deleip]

🐦 Purpose of this PR 🐦

• This PR introduces biomass demand for bioplastic production in 62_material. Future bioplastic production is projected as logistic curve defined by historic production in 2020 and the target maximum production and midpoint of the logistic function (s62_max_dem_bioplastic and s62_midpoint_dem_bioplastic). As default s62_max_dem_bioplastic is set to zero. In that case bioplastic is not considered in overall material demand.

🔧 Checklist for PR creator 🔧

• Labeling pull request correctly from the label list.

• Low risk : Simple bugfixes (missing files, updated documentation, typos) or Start/output scripts
• Medium risk : New realization / Changes to existing realization / Other changes which don't modify default.cfg
• High risk : New input files (if cfg$input is changed in default.cfg) / Modification to core model (eg. changes in equations, calculations, introduction of new sets etc.) / Other changes in default.cfg

• Providing additional information based on PR label

• Low risk : No new model run needed.
• Medium risk : Default run based on the current version of the fork from which PR is made
• High risk
  • Default run from the current develop branch
  • Default run based on the current version of the fork from which PR is made

• 📉 Performance loss/gain from current default behavior 📈

  • Current develop branch default : 21 mins
  • This PR's default : 24 mins

• Added changes to CHANGELOG.md

• Compilation check (model starts without compilation errors - use gams main.gms action=c in model folder for testing).

• No hard coded numbers and cluster/country/region names.

• The new code doesn't contain declared but unused parameters or variables.

• Where relevant, In-code comments added including documentation comments.

• Made sure that documentation created with goxygen is okay (use goxygen::goxygen() for testing).

• Changes to magpie4 R library for post processing of model output (ideally backward compatible).

• Self-review of my own code.

• In case of updated cellular input tgz file in default.cfg: scenario_config.csv has been updated accordingly (rcp1p9, rcp2p6 etc)

• For high risk runs: validation of major model indicators - Land-use, emissions, food prices, Tau. %Delete this line in case it is not a high risk run%

Results of bioplastic scenario (with max. demand 400 mio. t in 2050) compared to default:

⚠️ Additional notes or warnings ⚠️

NA

🚨 Checklist for RSE reviewer 🚨

• PR is labeled correctly.
• CHANGELOG is updated correctly
• No hard coded numbers and cluster/country/region names.
• No unnecessary increase in module interfaces
• All required updates in interfaces (if any) have been properly adressed in the module contracts
• In-code comments and documentation comments are satisfactory.
• model behavior/performance is satisfactory.
• Requested changes (if any) were applied correctly

🚨 Checklist for MAgPIE reviewer 🚨

• PR is labeled correctly.
• CHANGELOG is updated correctly
• No hard coded numbers and cluster/country/region names.
• Changes to the model are scientifically sound
• In-code comments and documentation comments are satisfactory.
• model behavior/performance is satisfactory.
• Requested changes (if any) were applied correctly

[bodirsky]

looks good, but a few naming convention issues, and biomass demand should be the total biomass, not just the one without the histprical quantity (what the model is doing is correct, but the output variabels should be close to the values that people want to use when writing a paper, so it should be total quantity)

[bodirsky]

it should be named biomass2bioplastic, because it is biomass/bioplastic, e.g. 2to1, 2:1, 2/1, not vice versa.
I would even call it
f62_biomass2bioplastic_conversion_ratio
The unit seems wrong, shoudl be tDM biomass/tDM bioplastic (for mathematicians this seems as it cancels out, but it doesnt because its strictly speaking two different types of tons)

[deleip]

true... unfortunately this is also wrong in the input file name - I guess it would be worth doing a new pre-processing revision for this, or should I only change the parameter name?

[bodirsky]

ah damn... a lot of effort for a single parameter, maybe just include it in one of your next PRs which requires new preprocessing...

[tscheypidi]

Looks good overall, mostly just some suggestions for improvements from my side. Only thing which I don't understand is why there is a special treatment for the case s62_max_dem_bioplastic = 0 and why this is happening in presolve, while the treatment of all other cases is in preloop. This should be clarified and ideally simplified.

[tscheypidi]

perhaps use ref instead of lastcalibyear(h) as it is basically your point of reference for the following calculations, right?

[tscheypidi]

why is this case treated separately and why in presolve and not in preloop where it is done for all other cases?

[deleip]

This was left over from an earlier version of handling the double counted bioplastic substrate. I moved it to preloop