-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New MACCs realization #442
Conversation
moving MACCs out of GHG policy module and into emission modules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these improvements!
As far as I can judge, your suggestions make sense content-wise.
Please add a summary of changes to the changelog file.
There seem to be left-over files from deleted module realizations. Please clean up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall. Just see the few requests for changes I made and in addition update CHANGELOG.md as also requested by Florian
We also need to adjust this function in the magpie4 R library. The output is used by REMIND. |
I updated the function such that it works with the model version in this PR as well as with the current develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I added some minor suggestions, mostly spelling corrections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the PIK specific descriptions and check whether the RCP change in inputs is intended. Otherwise, looks good to me
Co-authored-by: Florian Humpenöder <humpenoeder@pik-potsdam.de>
Co-authored-by: Florian Humpenöder <humpenoeder@pik-potsdam.de>
…develop # Conflicts: # CHANGELOG.md # config/default.cfg # main.gms
Co-authored-by: Florian Humpenöder <humpenoeder@pik-potsdam.de>
🐦 Purpose of this PR 🐦
The previous model version had two shortcomings:
a) The marginal abatement cost curves (MACCs) did reduce N2O emissions, but without changing the nitrogen cycle. In reality, most of the measures within the MACCs actually achieve a reduction of N2O emissions by improving nitrogen use efficiency (NUE), and therfore change the entire nitrogen cycle, including also other N-related pollutants.
b) The MACCs were subject to a potential double accounting in case the NUE was increased.
c) The emission factors of IPCC were based on the inputs, not on the losses. So, even in case of a 100% NUE when there can be by definition no emissions, soil emissions where still there, because also under a NUE of 100%, the nutrients removed by the harvest have to be replaced. The mitigation potential was therefore underestimated.
d) The scenarios of the NUE assumed a globaly uniform target value. That usually implied that NUEs fall slightly in HICs, while they rise rapidly in countries with low efficiencies (like China). This may be unrealistic.
The new PR solves a) and b) and uses the already existing "rescaled" implementation (non-default, but by now frequently tested) to achieve c). d) is achieved via new scenarios. A new set of scenarios now lead to less of decline in HICs and strong but slower improvements in countries with low efficiencies.
a) is solved by wiring the MACCs to the NUE. We transform the MACCs to an implementation that changes NUE in such a way that the change in NUE results in the same decline of emissions as the MACCs under the conditions of an NUE of 50% (global average). In case of a higher baseline NUE, they however result in a lower mitigation potential (as less of the losses can be reduced by these emissions. The formula is Losses = (1-NUE) = (1-NUE_base)(1-MACCs)
b) The formula Losses = (1-NUE) = (1-NUE_base)(1-MACCs) also takes care of the double accounting. It still assumes that the measures in the MACCs have an effect, yet this effect is reduced the higher the baseline NUE is. This means however, that the baseline NUEs have to be chosen more conservatively; i therefore included a number of new scenarios, which result in a comparable NUE as previous implementations only if they are combined with the MACCs.
The interfaces between the models was changed. Previous implementations were using the vm_btm_reg, so the emissions before technical mitigation, which were then translated into final emissions in the GHG policy module. In the new implementation, vm_btm_reg is abolished, and the MACCs are applied directly in the emisssions modules. This simplifies code, and allows for different MACCs implementations in different emission module realizations.
Results for the 5 SSPs with the new implementation are called maccs_test_v10
Results differ in terms of N2O emissions. In general they are lower, because NUE has improved in many world regions and the new implementation accounts for this. They are in particular lower in Europe and the USA, and higher in China. This is intended outcome.
Results also differ in terms of nitrogen cycle. Air pollutants and nitrate are now reduced in mitigation scenarios. Fertilizer application as well. This is also intended.
Old module realizations were removed. Otherwise, the change of interface from vm_btm_reg to vm_emissions_reg would not have been possible without inconsistencies.
🔧 Checklist for PR creator 🔧
no significant change in runtime
CHANGELOG.md
gams main.gms action=c
in model folder for testing).goxygen
is okay (usegoxygen::goxygen()
for testing).magpie4
R library for post processing of model output (ideally backward compatible).NA
🚨 Checklist for RSE reviewer 🚨
CHANGELOG
is updated correctly🚨 Checklist for MAgPIE reviewer 🚨
CHANGELOG
is updated correctly