-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added restart points and automatic restart support #512
Conversation
CHANGELOG.md
Outdated
- **59_som** added new **cellpool_jan23** realization with updated 2019 IPCC guidelines values | ||
- **config** added setting cfg$keep_restarts which controls whether restart files should be kept after a run finished | ||
- **scripts** added restart points after each time step from which the model can now be restarted if the simulation aborts at some point | ||
- **scripts** added start script which starts an empty model just regenerating a previous run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **scripts** added start script which starts an empty model just regenerating a previous run |
This is already in the changelog under 4.6.3
CHANGELOG.md
Outdated
- **31_past** added additional limitation (single climate scenario input) for **grasslands_apr22** | ||
- **59_som** added new **cellpool_jan23** realization with updated 2019 IPCC guidelines values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- **31_past** added additional limitation (single climate scenario input) for **grasslands_apr22** | |
- **59_som** added new **cellpool_jan23** realization with updated 2019 IPCC guidelines values |
This is already in the changelog under 4.6.3
@@ -147,24 +149,24 @@ $title magpie | |||
*##################### R SECTION START (VERSION INFO) ########################## | |||
* | |||
* Used data set: rev4.79_h12_magpie.tgz | |||
* md5sum: 4f3f5fd72716fe371d646c69c30e6fd3 | |||
* Repository: /p/projects/rd3mod/inputdata/output | |||
* md5sum: NA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but why is the md5sum NA when the data comes from our public repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idk
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this very useful feature!
The code looks fine to me.
However, there are changes in the model core.
Therefore, this qualifies as high risk PR (I changed this in the PR).
Please make test runs to check if the model results are unchanged.
Our labeling policy is here a bit vague, but I would still see this PR as a low risk one as there are no "critical changes" in the code: My PR does not contain any changes which would affect the way things are being calculated in the model. All changes are pure technical nature and I tested that they only get active in instances where they should. However, to be completely sure I also did now the set of test runs and as expected they are 1:1 identical to previous test runs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, our PR policy is a bit vague here.
Thanks for doing the test runs anyways.
🐦 Description of this PR 🐦
After this update the model will create restart files after each time steps and use these files if the model is stopped at some point and restarted (previously a restarted model would start again from the first time step)
In addition:
🔧 Checklist for PR creator 🔧
Label pull request from the label list.
Self-review own code
magpie4
R library has been updated accordingly and backwards compatible where necessary.scenario_config.csv
has been updated accordingly (important ifdefault.cfg
has been updated)Document changes
CHANGELOG.md
goxygen::goxygen()
and verify the modified code is properly documentedPerform test runs
Rscript start.R --> "compilation check"
Rscript start.R --> "test runs"
Rscript start.R --> "test runs"
📉 Performance changes 📈
🚨 Checklist for reviewer 🚨
CHANGELOG
is updated correctly