Add support to store sessions in Redis #310
Conversation
| if ( _log.isDebugEnabled() ) { | ||
| _log.debug( "Trying to store session in memcached: " + session.getId() ); | ||
| } | ||
|
|
||
| try { | ||
| storeSessionInMemcached( session, data ); | ||
| return new BackupResult( BackupResultStatus.SUCCESS, data, attributesData ); | ||
| } catch (final ExecutionException e) { |
There was a problem hiding this comment.
This one wrapped all exceptions that were thrown by the future task - without having further context I'd say that Exception or Throwable should now be caught as a proper replacement.
…ation using executor service in Redis client, some more comments and cleanup
| if (exp == 0) | ||
| return true; | ||
| else | ||
| return jedis.expire(kb, convertExp(exp)) == 1; |
There was a problem hiding this comment.
If the first attempt failed (where jedis.setnx actually caused the exception), wouldn't the next try (with another connection) potentially expire an existing session?
There was a problem hiding this comment.
Nevermind, jedis.setnx couldn't have caused the exception because _setCompleted wouldn't be true then. Instead jedis.expire must have caused the first exception. Therefore an existing session should not be expired by this call.
|
@msellinger FYI: I'm starting to work on this, first things was a rebase/squash. The WIP is in branch pr-18-redis-support ... (if I don't forget it I'm marking resolved stuff with a 👍 ) |
|
I'm through it, tests passed, pushed changes to pr-18-redis-support (I'll squash commits before merging...). Would be great if you could use this for testing. |
|
Awesome work, thank you!! We are setting up our staging environment on AWS this week and I will use the version built from this branch for testing. |
|
👍 |
|
Hi Markus, I just merged the branch and released 2.0.0. I didn't manage to introduce "storageNodes" deprecating "memcachedNodes". Thanks a lot for this contribution again! Cheers, |
|
Thank you, that's exciting. What about adding documentation to use Redis? Do you need some input for that? I see that I seem to be able to "Edit" the Wiki (is it normal that this is world-writeable?), but should I? Also, maybe on the start page one should mention that as of 2.0.0, not only memcached but also Redis is supported. |
No description provided.