Details Popup Window

[mahammad-mostafa]

• Built an object array for holding all projects information
• Dynamically loaded all projects into the work section
• Implemented popup window according to design
• Created click events for handling closing and opening
• Loaded the popup window with the relevant project details

[Efiamotu-1]

Hi @mahammad-mostafa ,

Good job so far! 👏. Your Code is Awesome! 💪

There are some few issues 🐛 that you still need to work 🔧 on though to go to the next project ⏭️ but you are almost there! 🏃

Don't Worry 🙏

It's ok to have bugs in your code 🐛. Please, see this code review as a chance for you to learn practical coding skills and learn new tips that can improve your code quality 💯 and help you **get a better ** 💼.

I am going to guide you on how to fix them down below. 🤓

Highlights 🎯

• ✔️ No linter Errors
• ✔️ Descriptive README
• ✔️ Descriptive PR title and description
• The code is top-notch! 💯 and has a huge potential.

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Important Notes 📝

• Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
• Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

Note: Please, don't Merge This Pull Request yet. Only Merge when it is Approved ✅.

Thank you for your time 🙏 and call me if you need help or clarification ☎️

• This is My GitHub:
• This is My Twitter:
• This is My linkedIn.
• This is My Slack:

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[Efiamotu-1]

• The image for each popup should be dynamically displayed just like every other content. Currently what you have is a single image shwoing for all project, however each project has its own image and this should be what is shown once the user clicks to see the project. please kindly make this desired change so that your popup implementation can be complete. you have done a great job already 👍 ✨

• see this project's example image below

• Expected pop-up
  
• Your pop-up
  

[usorfaitheloho]

Hi @mahammad-mostafa 👋,

STATUS: APPROVED 🕺🥳

Congratulations🍾🥳!! Your project is ready for presentation! There is nothing else to say other than... it's time to merge it

Good luck! 🎉

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[usorfaitheloho]

[Optional]

kindly work on the mobile view of your popup modal as it seems to be having some scrolling issues hence the close button doesn't display on the screen. It was supposed to be a mandatory requirement but I think it was omitted by the previous reviewer so please fix it 😄

Your design :

[mahammad-mostafa]

Thanks a lot @usorfaitheloho for your thorough review!
I have fixed the scrolling issue successfully 👌🏻