-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details Popup Window #11
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
ad7c238
Added link icon
mahammad-mostafa efa2210
Added popup image
mahammad-mostafa 53c02bf
Removed buggy webhint linter
mahammad-mostafa c475e13
Built popup window
mahammad-mostafa e864c0b
Styled popup window for mobile & desktop
mahammad-mostafa e8a91cc
Implemented popup window loading and click events
As1imwe-Mark 61d6ed0
Moved script to assets folder
mahammad-mostafa f1b94bd
Fixed linter errors
mahammad-mostafa b504377
Made image dynamic with project content
mahammad-mostafa 3fefee2
Removed static popup image
mahammad-mostafa c1f9e89
Fixed popup scrolling
mahammad-mostafa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Optional]
kindly work on the mobile view of your popup modal as it seems to be having some scrolling issues hence the
close
button doesn't display on the screen. It was supposed to be a mandatory requirement but I think it was omitted by the previous reviewer so please fix it 😄Your design :
![image](https://private-user-images.githubusercontent.com/20537712/247804784-5b701bc0-871c-41ec-b974-7aebe39efc5f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjEyMjM2NTksIm5iZiI6MTcyMTIyMzM1OSwicGF0aCI6Ii8yMDUzNzcxMi8yNDc4MDQ3ODQtNWI3MDFiYzAtODcxYy00MWVjLWI5NzQtN2FlYmUzOWVmYzVmLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE3VDEzMzU1OVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQ3MzgyZDc3M2EwOGFjMTgwYzEzNDhhNzI2NzhjMWI1YWYyZTI5ZDFkNTVjNDg0ZGQzNjMxMjdlNDc2NjI5MmImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.flICZJOzzZRv6NAN0BMq_DwrrkUOL54Ki-x0zlLeSs4)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @usorfaitheloho for your thorough review!
I have fixed the scrolling issue successfully 👌🏻