Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve/Provide metric descriptions in legend #2377

Closed
ce-bo opened this issue Sep 20, 2021 · 0 comments · Fixed by #2421
Closed

Improve/Provide metric descriptions in legend #2377

ce-bo opened this issue Sep 20, 2021 · 0 comments · Fixed by #2421
Assignees
@jannikr
Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO

Comments

@ce-bo
Copy link
Collaborator

ce-bo commented Sep 20, 2021 •
edited

Feature request

As a UX Engineer, I want to prevent empty metric descriptions in the legend, so that Users of CodeCharta are not supposed to be confused.

Acceptance criteria

  • The metric label is not shown, if no description is available.
  • More basic metric descriptions are provided. Especially for loc and comment_lines

image
@ce-bo ce-bo added bug Only issues that describe bugs. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. javascript Pull requests that update Javascript code. Usually created by Dependabot. difficulty:low Solving this is likely not that difficult labels Sep 20, 2021
@BridgeAR BridgeAR added the priority:high Set by PO label Sep 20, 2021
@jannikr jannikr self-assigned this Oct 4, 2021
jannikr added a commit that referenced this issue Oct 4, 2021
@jannikr
Hide legend block if label description is not available #2377
1b674d7
jannikr added a commit that referenced this issue Oct 4, 2021
@jannikr
Add new descriptions #2377
ba6d8e8
jannikr added a commit that referenced this issue Oct 4, 2021
@jannikr
Update Changelog #2377
db355b4
@jannikr jannikr mentioned this issue Oct 4, 2021
Merged
jannikr added a commit that referenced this issue Oct 5, 2021
@jannikr
Add change to be able to display metrics cleanly even without descrip…
2bf02cf 
…tion. #2377
jannikr added a commit that referenced this issue Oct 7, 2021
@jannikr @Shivan-997
Fix/2377/improve metric descriptions in legend (#2421)
b082775 
* Hide legend block if label description is not available #2377

* Add new descriptions #2377

* Update Changelog #2377

* Add change to be able to display metrics cleanly even without description. #2377

Co-authored-by: Shivan-997 <57844849+Shivan-997@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jannikr jannikr

Labels
bug Only issues that describe bugs. difficulty:low Solving this is likely not that difficult javascript Pull requests that update Javascript code. Usually created by Dependabot. pr-visualization Issues that touch the visualization pr(oject) which means web and desktop features. priority:high Set by PO
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix/2377/improve metric descriptions in legend MaibornWolff/codecharta
3 participants
@BridgeAR @ce-bo @jannikr