Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Simple server cleanup #30

Merged
merged 5 commits into from
Feb 16, 2016
Merged

Simple server cleanup #30

merged 5 commits into from
Feb 16, 2016

Conversation

canndrew
Copy link
Contributor

Review on Reviewable

@maidsafe-highfive
Copy link

r? @vinipsmaker

(maidsafe_highfive has picked a reviewer for you, use r? to override)

@canndrew
Copy link
Contributor Author

I'd ignore this for now @vinipsmaker because some of it conflicts with your PR #18. I'll fix it up or close it later when that PR is merged.

@canndrew
Copy link
Contributor Author

This should be good to go if checks pass.

@vinipsmaker
Copy link
Contributor

This should be good to go if checks pass.

The checks aren't running. Need to ping @rossmuir about it.

@vinipsmaker
Copy link
Contributor

Can I close #27 given all commits there are present in this PR?

@Fraser999 Fraser999 closed this Feb 15, 2016
@Fraser999 Fraser999 reopened this Feb 15, 2016
@vinipsmaker
Copy link
Contributor

Reviewed 8 of 10 files at r1, 1 of 2 files at r2, 1 of 1 files at r3.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io

vinipsmaker added a commit that referenced this pull request Feb 16, 2016
@vinipsmaker
Merge pull request #30 from canndrew/simple-server-cleanup
8207018 
Simple server cleanup
@vinipsmaker vinipsmaker merged commit 8207018 into maidsafe-archive:master Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@canndrew @maidsafe-highfive @vinipsmaker @Fraser999