-
Notifications
You must be signed in to change notification settings - Fork 13
Conversation
r? @vinipsmaker (maidsafe_highfive has picked a reviewer for you, use r? to override) |
Can you rebase against |
Right, I will after I've fixed the tests. |
Do not forget to ping me, as |
Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion. src/socket_utils.rs, line 22 [r2] (raw file): Comments from the review on Reviewable.io |
Reviewed 8 of 10 files at r1, 3 of 3 files at r2. Comments from the review on Reviewable.io |
Please rebase against |
Reenables the
unused
lint and cleans up the result.Also, changes the return type of
PunchedUdpSocket::punch_hole
to return aWResult
, this is the only change that will effect crust.