Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

Clean up #27

Merged
merged 4 commits into from
Feb 16, 2016
Merged

Clean up #27

merged 4 commits into from
Feb 16, 2016

Conversation

canndrew
Copy link
Contributor

Reenables the unused lint and cleans up the result.
Also, changes the return type of PunchedUdpSocket::punch_hole to return a WResult, this is the only change that will effect crust.

Review on Reviewable

@maidsafe-highfive
Copy link

r? @vinipsmaker

(maidsafe_highfive has picked a reviewer for you, use r? to override)

@vinipsmaker
Copy link
Contributor

Can you rebase against master and ping me back?

@canndrew
Copy link
Contributor Author

Right, I will after I've fixed the tests.

@vinipsmaker
Copy link
Contributor

Right, I will after I've fixed the tests.

Do not forget to ping me, as GitHub won't notify me of new commits or tests passing/failing.

@vinipsmaker
Copy link
Contributor

Review status: 0 of 11 files reviewed at latest revision, 1 unresolved discussion.


src/socket_utils.rs, line 22 [r2] (raw file):
Do we need commented code?


Comments from the review on Reviewable.io

@vinipsmaker
Copy link
Contributor

Reviewed 8 of 10 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion, some commit checks failed.


Comments from the review on Reviewable.io

@vinipsmaker
Copy link
Contributor

This branch has conflicts that must be resolved

Please rebase against master.

@vinipsmaker vinipsmaker mentioned this pull request Feb 15, 2016
@vinipsmaker vinipsmaker merged commit a6d83c2 into maidsafe-archive:master Feb 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants