Use structopt for command line arguments #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes the library usage more flexible: with structopt flatten we can create CLI apps which can inherit configuration options from quic-p2p.
…atforms It is not supported on Android/iOS and embedded platforms so we don't need it. Also add placeholders for project_dir.
ustulation
suggested changes
Apr 22, 2019
| @@ -13,7 +13,7 @@ use crate::error::Error; | |||
| use serde::de::DeserializeOwned; | |||
| use serde::Serialize; | |||
| use std::fs::File; | |||
| use std::io::{self, BufReader, BufWriter}; | |||
| use std::io::{BufReader, BufWriter}; | |||
There was a problem hiding this comment.
It's not used on non-T1/mobile platforms (see the project_dir impl below)
ustulation
suggested changes
Apr 22, 2019
src/config.rs
Outdated
| pub idle_timeout_msec: Option<u64>, | ||
| /// Interval to send keep-alives if we are idling so that the peer does not disconnect from us | ||
| /// declaring us offline. If none is supplied we'll default to the documented constant. | ||
| /// | ||
| /// The interval is in milliseconds. A value of 0 disables this feature. | ||
| #[structopt(long)] | ||
| pub keep_alive_interval_msec: Option<u32>, | ||
| /// Path to our TLS Certificate. This file must contain `SerialisableCertificate` as content |
There was a problem hiding this comment.
Ah this is not correct - can we pls change it to say it's not a path we are asking but the certificate itself ?
ustulation
approved these changes
Apr 23, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this library gives us more flexibility in ways users can configure the options provided by the library.
This PR also includes some changes in
directories/config file loader handling (e.g., it also takes mobile platforms into account).