feat(faucet): create distributions for maid addrs #1248
Conversation
Sounds good if that can be done easily?
I think we'll need that and for the CI in general (aside from probably a test that will verify that distributions have occured perhaps?) (That might be one for a follow up PR?) |
sn_faucet/src/faucet_server.rs
Outdated
| snapshot: Snapshot, | ||
| pubkeys: HashMap<MaidAddress, MaidPubkey>, | ||
| ) { | ||
| for (addr, amount) in snapshot { |
There was a problem hiding this comment.
Here I think we can push each iteration into its own task and then use futures::join_all to collect and ensure that's happening.
And then if this whole function is tokio::spawned we'll get a fast startup 👍
There was a problem hiding this comment.
It seemed simpler to just put the whole distribute function in a thread rather than do a bunch of spawning, because transfers can't happen in parallel (wait for wallet lock to be released).
iancoleman
force-pushed
the
distributions
branch
from
ce1044d
to
6674cd7
Compare
|
Rebased on main after #1253 was merged |
|
How to fix this failing test for unused dependencies? They are used but only in -run: cargo +nightly udeps --all-targets
+run: cargo +nightly udeps --all-targets --features distributionbut this feels like the wrong way to do it (maybe my feeling is wrong). Any tips or advice @grumbach @joshuef ? |
|
@iancoleman i'm not wholly sure. I've pinged @RolandSherwin as he might have more idea, but right now we could manually ignore them via the If there's no immediate better way, I'd do just that. |
|
ah, @RolandSherwin has sorted it. Thanks!! 🙇 (was |
This PR changes the faucet startup process. At startup the faucet creates distributions of tokens using the snapshot of maid addresses + balances + public keys.
Each distribution is a combination of a transfer (from the faucet) and an encrypted secret key (randomly generated) that enables that transfer to be spent. The maid owner can decrypt the secret key using their maid private key, which is then used as a wallet key for spending the transfer.
Distributions created by the faucet are saved to
$HOME/.local/share/safe_snapshot/distributions/<address>and contain the messagepack-encoded hex for the distribution.Note:
This doesn't enable access to the distributions yet, this is to be done in future work by exposing a faucet server endpoint that returns the distribution for a particular maid address. I'm trying to keep each PR relatively small.
The startup process for the faucet server has become much longer while it creates these distributions. Creating 1200 initial distributions took about 11 minutes.
Future work will be:
allow users to fetch their distribution from the cli for their maid address, and automatically send that distribution to their wallet.
enable the faucet to receive new maid address+publickey pairs and create new distributions on the fly for those.
expose the full snapshot and distribution list to enable audit of the process. Need to explore what an audit would require.
find a simple / automatic way to retain address + publickeys that have been submitted while the faucet is running, stored in maid_address_pubkeys.csv for future use.
consider adding a test maid address to this so we can test the claim process easily.
Description
Summary generated by Reviewpad on 31 Jan 24 03:07 UTC
This pull request includes changes to the Cargo.lock, Cargo.toml, and faucet_server.rs files. It updates dependencies and adds new ones, including "ecies", "libsecp256k1", "libsecp256k1-core", "libsecp256k1-gen-ecmult", "libsecp256k1-gen-genmult", "rmp-serde", and "serde_bytes". It also adds structs and functions related to distributing tokens to addresses using public and secret keys.