Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make token distribution an option #1253

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

grumbach
Copy link
Member

@grumbach grumbach commented Feb 1, 2024

Description

Summary generated by Reviewpad on 01 Feb 24 09:08 UTC

This pull request contains the following changes:

  • The main.rs file adds a new module token_distribution when the feature "distribution" is enabled.

  • The Cargo.toml file adds a new feature called distribution, with the value set to ["bitcoin"]. It also modifies the dependency on bitcoin to include optional = true.

  • The token_distribution.rs file is a new file added to the sn_faucet/src directory. It includes code for loading and managing the distribution of tokens in the MaidSafe network, defines constants and types, and introduces structs for representing MaidSafe balances and snapshots.

  • The faucet_server.rs file underwent several changes, including the addition of #[cfg(feature = "distribution")] attribute to conditionally include code based on the "distribution" feature. It also removes imports, constants, types, and functions, modifies existing functions, and conditional loading of maide_snapshot and maide_pubkeys from the token_distribution module.

If you need further assistance or explanation on any of these changes, please let me know.

@reviewpad reviewpad bot requested a review from iancoleman February 1, 2024 09:08
@reviewpad reviewpad bot added Large Large sized PR waiting-for-review labels Feb 1, 2024
@iancoleman
Copy link
Contributor

@joshuef feel free to merge whenever ready, I'll leave the merge button to maidsafers!

@joshuef joshuef added this pull request to the merge queue Feb 2, 2024
Merged via the queue into maidsafe:main with commit 0934948 Feb 2, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Large Large sized PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants