Feat: move folders/files metadata out of Folders entries #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
from
16d73ad
to
5c3bbb2
Compare
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
from
5c3bbb2
to
b7f2036
Compare
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
from
b7f2036
to
3648f53
Compare
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
from
3648f53
to
37999d3
Compare
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
2 times, most recently
from
9829fbb
to
a60e10c
Compare
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
4 times, most recently
from
b22d42e
to
cbe3156
Compare
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
3 times, most recently
from
92ce84f
to
1ce392f
Compare
bochaco
force-pushed
the
feat-folders-metadata-into-chunks
branch
from
1ce392f
to
5c34bd3
Compare
joshuef
approved these changes
Feb 20, 2024
| fn add_entry(&mut self, name: OsString, content: FolderEntry) -> Result<(Metadata, XorName)> { | ||
| // create metadata Chunk for this entry | ||
| let metadata = Metadata { | ||
| name: name.to_str().unwrap_or("unknown").to_string(), |
There was a problem hiding this comment.
Should this be just the OsString? The previous todo said the following
// TODO: conversion to String will be removed when metadata is moved out of the Register
There was a problem hiding this comment.
there is a problem with wasm build and unsafe api from OsString, it needs more investigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also makes it possible to sync/compare local changes with remote version of folders/files.
Requires PR #1304 .
Requires PR #1311 .
Description
reviewpad:summary