Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): allow to pass files iterator to chunk-mgr and files-upload tools #1311

Merged

Conversation

bochaco
Copy link
Member

@bochaco bochaco commented Feb 14, 2024

Also allow to use different paths for local wallet dir and chunk-mgr artifacts/cache.

Description

reviewpad:summary

@bochaco bochaco force-pushed the feat-diff-path-for-chunks-artifacts-and-wallet branch from 6d902eb to 5943277 Compare February 15, 2024 15:37
@bochaco bochaco changed the title feat(cli): use different paths for local wallet and chunk-mgr artifacts refactor(cli): allow to pass files iterator to chunk-mgr and files-upload tools Feb 15, 2024
@bochaco bochaco force-pushed the feat-diff-path-for-chunks-artifacts-and-wallet branch from 5943277 to bc3cae9 Compare February 15, 2024 15:38
@bochaco bochaco marked this pull request as ready for review February 15, 2024 15:38
@bochaco bochaco force-pushed the feat-diff-path-for-chunks-artifacts-and-wallet branch from bc3cae9 to 5c41869 Compare February 15, 2024 15:50
…load tools

Also allow to use different paths for local wallet dir and chunk-mgr artifacts/cache.
@bochaco bochaco force-pushed the feat-diff-path-for-chunks-artifacts-and-wallet branch from 5c41869 to a787962 Compare February 15, 2024 20:37
@bochaco bochaco marked this pull request as draft February 15, 2024 20:48
@bochaco bochaco marked this pull request as ready for review February 18, 2024 17:16
@joshuef joshuef added this pull request to the merge queue Feb 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2024
@joshuef joshuef merged commit 5dd7bb3 into maidsafe:main Feb 19, 2024
56 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants