chore: rotate logs after exceeding 20mb #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous rotation strategy was using the number of lines, which was set to 5000. Users recently noticed this limitation was producing lots of logs, so we've changed the strategy to be based on the size of the log in bytes.
jacderida
force-pushed
the
log-rotation
branch
from
d947e02
to
a393075
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous rotation strategy was using the number of lines, which was set to 5000.
Users recently noticed this limitation was producing lots of logs, so we've changed the strategy to be based on the size of the log in bytes.
Description
Summary generated by Reviewpad on 06 Sep 23 19:14 UTC
This pull request updates the log rotation strategy in the
sn_logginglibrary. Previously, logs were rotated based on the number of lines, but this caused an excessive number of logs. The new strategy rotates logs based on the size of the log in bytes. This change is implemented in theappender.rsandlib.rsfiles. The maximum log size is set to 20mb, the maximum number of uncompressed log files is set to 100, and the maximum number of log files is set to 1000.