feat: publish to non-subscribed topic #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
from
7789f9b
to
50ba226
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
2 times, most recently
from
8e74013
to
7fba5de
Compare
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
from
7fba5de
to
4831fb5
Compare
reviewpad
bot
added
Medium
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
2 times, most recently
from
ccfdd4c
to
e381bb6
Compare
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
from
df0a573
to
dbad54a
Compare
|
Marking as DoNotMerge so we can assess this... Does it lower mem usage any? CPU? Would be good to know concretely what we get from this. |
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
3 times, most recently
from
7aa6193
to
f2a6ccc
Compare
bochaco
previously requested changes
Nov 14, 2023
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
from
f2a6ccc
to
9257008
Compare
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
from
9257008
to
973335e
Compare
reviewpad
bot
added
Small
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
2 times, most recently
from
067017f
to
9ae3b77
Compare
joshuef
approved these changes
Nov 29, 2023
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
from
70dca4a
to
b38c3c6
Compare
maqi
force-pushed
the
publish_to_non_subscribed_topic
branch
from
b38c3c6
to
4994dee
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 28 Nov 23 16:12 UTC
This pull request adds a new feature where most of the nodes do not subscribe to the "TRANSFER_NOTIFICATION" topic. The patch modifies several files including
sn_cli/src/subcommands/wallet.rs,sn_node/src/lib.rs,sn_node/src/node.rs,sn_node/src/put_validation.rs,sn_node/tests/nodes_rewards.rs, andsn_node_rpc_client/src/main.rs. The changes include renaming the constantTRANSFER_NOTIF_TOPICtoROYALTY_TRANSFER_NOTIF_TOPIC, updating the subscription to the new topic in thelisten_notifs_and_depositfunction, and handling messages for the new topic in theprocess_eventfunction. Additionally, the patch introduces a new constantFORWARDER_CHOOSING_FACTORwhich determines the number of nodes acting as forwarders for the subscription.