feat: for royalty transfer, subscribe and publish to sub-group only #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
reduce_gossipsub_subscriptions
branch
from
31525e0
to
f2df854
Compare
maqi
force-pushed
the
reduce_gossipsub_subscriptions
branch
from
f2df854
to
0f1902e
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -372,7 +394,9 @@ | |||
| NetworkEvent::GossipsubMsgReceived { topic, msg } | |||
| | NetworkEvent::GossipsubMsgPublished { topic, msg } => { | |||
| if self.events_channel.receiver_count() > 0 { | |||
| if topic == TRANSFER_NOTIF_TOPIC { | |||
| // TODO: shall record which topics this network instance subscribed. | |||
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
maqi
force-pushed
the
reduce_gossipsub_subscriptions
branch
from
3f641a0
to
ba66262
Compare
|
In favour of the PR #933 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 02 Nov 23 14:51 UTC
This pull request adds a new feature for royalty transfer by subscribing and publishing to a sub-group only. It also modifies the logic for subscribing and publishing transfer notifications using gossipsub. This change improves the efficiency and specificity of notifications for royalty payments.