Commits on May 8, 2019

1. Make StateMachine impl more robust

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 02b454d
   • Browse repository at this point

   Copy the full SHA

   02b454d View commit details

   Browse the repository at this point in the history

2. Remove duplication in handle_new_message

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 4decffb
   • Browse repository at this point

   Copy the full SHA

   4decffb View commit details

   Browse the repository at this point in the history

3. Extract common state functionality into traits

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 2569de1
   • Browse repository at this point

   Copy the full SHA

   2569de1 View commit details

   Browse the repository at this point in the history

4. Extract Approved trait from Node

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 40be888
   • Browse repository at this point

   Copy the full SHA

   40be888 View commit details

   Browse the repository at this point in the history

5. Extract EstablishingNode from Node

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for ae598cb
   • Browse repository at this point

   Copy the full SHA

   ae598cb View commit details

   Browse the repository at this point in the history

6. Fix failures in node_drops, node_restart tests …

   - Try to reconnect to a dropped peer immediatelly, not delayed
   - Change `has_unconsensused_observations` to `has_unpolled_observations` to prevent terminating the tests prematurely
   - If node loses all connections, emit `RestartRequired` even if we are the first node (unless during network startup).
   - Randomize the drop order in the node_restart test to make it more likely to catch bugs

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for d90e779
   • Browse repository at this point

   Copy the full SHA

   d90e779 View commit details

   Browse the repository at this point in the history

7. Handle msg_backlog when transition to EstablishingNode

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 89bc2cd
   • Browse repository at this point

   Copy the full SHA

   89bc2cd View commit details

   Browse the repository at this point in the history

8. Reject BootstrapRequest when not established

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 8c46b97
   • Browse repository at this point

   Copy the full SHA

   8c46b97 View commit details

   Browse the repository at this point in the history

9. Minor fix in sending RoutingMessage as unestablished …

   Also move send_signed_message_to_peer from Relocated back to Node, as it is only used there.

   

   madadam committed May 8, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 3382ef7
   • Browse repository at this point

   Copy the full SHA

   3382ef7 View commit details

   Browse the repository at this point in the history

10. Simplify state conversions

    

    madadam committed May 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 988e0c5
    • Browse repository at this point

    Copy the full SHA

    988e0c5 View commit details

    Browse the repository at this point in the history

11. Reduce coupling between states

    

    madadam committed May 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 402c71b
    • Browse repository at this point

    Copy the full SHA

    402c71b View commit details

    Browse the repository at this point in the history

12. Rename NotEstablished to BootstrappedNotEstablished

    

    madadam committed May 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for fae3fba
    • Browse repository at this point

    Copy the full SHA

    fae3fba View commit details

    Browse the repository at this point in the history

13. Rename Bootstrapping to BootstrappingPeer …

    So all state names are nouns now, for consistency.

    

    madadam committed May 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for ed5b713
    • Browse repository at this point

    Copy the full SHA

    ed5b713 View commit details

    Browse the repository at this point in the history

14. Make state conversions more explicit …

    Change the return type of the various `into_` function to `Result<State>` so in case of error we return `Err` instead of silently ignoring it and returning `State::Terminated`.

    

    madadam committed May 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for 2dd16fb
    • Browse repository at this point

    Copy the full SHA

    2dd16fb View commit details

    Browse the repository at this point in the history

15. Improve mock parsec performance

    

    madadam committed May 8, 2019
    Configuration menu

    • View commit details
    • Copy full SHA for a648b9b
    • Browse repository at this point

    Copy the full SHA

    a648b9b View commit details

    Browse the repository at this point in the history