This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 81
Refactor Node state: extract EstablishingNode state #1616
Merged
Viv-Rajkumar
merged 15 commits into
maidsafe:fleming
from
madadam:node-state-refactor-part-two
May 9, 2019
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
02b454d
Make StateMachine impl more robust
madadam 4decffb
Remove duplication in handle_new_message
madadam 2569de1
Extract common state functionality into traits
madadam 40be888
Extract Approved trait from Node
madadam ae598cb
Extract EstablishingNode from Node
madadam d90e779
Fix failures in node_drops, node_restart tests
madadam 89bc2cd
Handle msg_backlog when transition to EstablishingNode
madadam 8c46b97
Reject BootstrapRequest when not established
madadam 3382ef7
Minor fix in sending RoutingMessage as unestablished
madadam 988e0c5
Simplify state conversions
madadam 402c71b
Reduce coupling between states
madadam fae3fba
Rename NotEstablished to BootstrappedNotEstablished
madadam ed5b713
Rename Bootstrapping to BootstrappingPeer
madadam 2dd16fb
Make state conversions more explicit
madadam a648b9b
Improve mock parsec performance
madadam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't done yet because you would want to update Parsec to one that exposes the new API in the same PR?
I would add this to the comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'd like to make the change in Parsec first, to avoid the situation where routing becomes uncompilable with
--features=mock_base
(that is, with real parsec).