This repository has been archived by the owner on Jun 25, 2021. It is now read-only.
feat: notify when key got changed during relocation #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madadam
reviewed
Nov 19, 2020
src/event.rs
Outdated
| @@ -78,6 +79,8 @@ pub enum Event { | |||
| Relocated { | |||
| /// Old name before the relocation. | |||
| previous_name: XorName, | |||
| /// Serialised new keypart. Use Keypair::from_bytes to re-construct. | |||
There was a problem hiding this comment.
cloning will be problematic espically out of the crate ?
There was a problem hiding this comment.
Pass it as Arc<Keypair> (it's how it's kept in Node anyway). By passing the bytes you are basically bypassing the whole security thing where we are trying to avoid having multiple copies of the key in memory.
maqi
force-pushed
the
notify_key_changed
branch
from
4a3ec3b
to
86d69f5
Compare
maqi
changed the title
madadam
approved these changes
Nov 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.