Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polish the ui #15

Open
maifeeulasad opened this issue Dec 17, 2020 · 11 comments
Open

polish the ui #15

maifeeulasad opened this issue Dec 17, 2020 · 11 comments
Labels
enhancement New feature or request

Comments

@maifeeulasad
Copy link
Owner

No description provided.

@maifeeulasad maifeeulasad added the enhancement New feature or request label Dec 17, 2020
@smolnp
Copy link
Contributor

smolnp commented Dec 17, 2020

More detailed descriptions are needed here. What exactly do you want to change?

@maifeeulasad
Copy link
Owner Author

Some icon changes, like you did to yours, and I don't know some where talking about GTK style in Qt, I don't know much about those but they looked cool.

@smolnp
Copy link
Contributor

smolnp commented Dec 17, 2020

This is not difficult. I'll take the time to provide the icons and make a merge request.

@smolnp
Copy link
Contributor

smolnp commented Dec 17, 2020

2012-1
Need to replace icons with system icons?

@maifeeulasad
Copy link
Owner Author

@smolnp #26 caused, some issue regarding eraser and selection icons, please check this out :

Screenshot from 2020-12-18 01-05-31

And from now on we will try to use git flow, every issue will be treated as a feature and will be pushed to a different branch.

Btw, JP looks cool.

@smolnp
Copy link
Contributor

smolnp commented Dec 17, 2020

Because the icons refer to the Breeze or Papirus themes. Your icons are not needed in this option. I have not yet made a request for a complete change of this file. To use your icons they need to be taught to change color when using a dark or light theme.

@smolnp
Copy link
Contributor

smolnp commented Dec 17, 2020

Now I will return to its original state.

maifeeulasad added a commit that referenced this issue Dec 18, 2020
@maifeeulasad
Copy link
Owner Author

some ui that looks really cool : https://www.youtube.com/watch?v=sc-Cs2Md8s8

@smolnp
Copy link
Contributor

smolnp commented Dec 19, 2020

I want to make the same sidebar layout.
Screenshot_20201219_171757
Should I make a pull request?

@maifeeulasad
Copy link
Owner Author

@smolnp I think you should. And it would be more cool, if they appear and disappear.

@smolnp
Copy link
Contributor

smolnp commented Dec 19, 2020

For now, I need to sketch, and the rest, I hope to work out.

maifeeulasad added a commit that referenced this issue Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants