Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

be more general when getting key from hex #52

Closed
6 tasks
todo bot opened this issue Apr 14, 2019 · 35 comments
Closed
6 tasks

be more general when getting key from hex #52

todo bot opened this issue Apr 14, 2019 · 35 comments
Assignees
@developerfred
Labels
area/sender bounty-awaiting-approval bounty-xs cmd/mailchain protocol/substrate Stale
Projects
protocol/substrate
Milestone
v0.1.0

Comments

@todo
Copy link

todo bot commented Apr 14, 2019 •
edited by robdefeo

Is your feature request related to a problem? Please describe.
With the introduction of substrate, when sending a message the public key type needs to be specified, the client will now send public-key-encoding and public-key-kind mailchain/mailchain-web#146

Describe the solution you'd like
@todo todo bot assigned robdefeo Apr 14, 2019
@todo todo bot added the todo 🗒️ label Apr 14, 2019
@stale
Copy link

stale bot commented Aug 12, 2019 •
edited by tboeckmann

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Mailchain team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply with all of the information you have about it in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please tell us why. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added Stale and removed Stale labels Aug 12, 2019
@robdefeo robdefeo added this to the v0.1.0 milestone Oct 26, 2019
@robdefeo
Copy link
Member

This should look at the public_key_encoding and key_type to determine what encoding is used and how the key should be created.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it.

@sameer2800
Copy link

can you elaborate a little more on what exactly to be more general here.

@developerfred
Copy link
Contributor

I will start this issue.

@robdefeo robdefeo mentioned this issue Nov 13, 2019
Closed
3 tasks
@robdefeo
Copy link
Member

#381 needs to be completed before this can be merged

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

11 similar comments
@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

@Liquid369 Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@robdefeo robdefeo mentioned this issue Feb 2, 2020
Closed
@robdefeo robdefeo removed their assignment Feb 3, 2020
@olimpias
Copy link
Contributor

olimpias commented Feb 4, 2020

Hi @robdefeo, could you assign it to me?

@developerfred
Copy link
Contributor

@olimpias already started working on this issue?

@gitcoinbot
Copy link

gitcoinbot commented Feb 4, 2020 •
edited

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 2 months ago.
Please review their action plans below:

1) developerfred has been approved to start work.

I would love to do this issue.

Learn more on the Gitcoin Issue Details page.

developerfred added a commit to developerfred/mailchain that referenced this issue Feb 4, 2020
@developerfred
[x] use correct encoding method from encoding package to decode bytes …
a4a8b1c 
…mailchain#52
@olimpias
Copy link
Contributor

olimpias commented Feb 4, 2020

Hi @developerfred, I havent started yet. I m planning to work on it tomorrow. I guess, you want to work on it. Am I right? You can have it, if it is the case.

@developerfred
Copy link
Contributor

yes, thanks @olimpias. needing something just call me

@olimpias olimpias removed their assignment Feb 4, 2020
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 5, 2020
@developerfred
expand PostMessage in cmd/mailchain/internal/http/handlers/send_messa…
1a13ecf 
…ge.go to include public-key-encoding and public-key-kind mailchain#52
@developerfred developerfred mentioned this issue Feb 5, 2020
Merged
6 tasks
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 5, 2020
@developerfred
expand PostMessage in cmd/mailchain/internal/http/handlers/send_messa…
db00402 
…ge.go to include public-key-encoding and public-key-kind mailchain#52
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 5, 2020
@developerfred
expand PostMessage in cmd/mailchain/internal/http/handlers/send_messa…
fc10e38 
…ge.go to include public-key-encoding and public-key-kind mailchain#52
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 6, 2020
@developerfred
expand PostMessage in cmd/mailchain/internal/http/handlers/send_messa…
f6e02a1 
…ge.go to include public-key-encoding and public-key-kind mailchain#52

*validate public_key_encoding use encoding/consts.go
*use correct encoding method
*use crypto/multikey.PublicKeyFromBytes
*create tests using external files
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 6, 2020
@developerfred
expand PostMessage in cmd/mailchain/internal/http/handlers/send_messa…
e77aaf8 
…ge.go to include public-key-encoding and public-key-kind mailchain#52

*validate public_key_encoding use encoding/consts.go
*use correct encoding method
*use crypto/multikey.PublicKeyFromBytes
*create tests using external files
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 6, 2020
@developerfred
expand PostMessage in cmd/mailchain/internal/http/handlers/send_messa…
1cb826d 
…ge.go to include public-key-encoding and public-key-kind mailchain#52

*validate public_key_encoding use encoding/consts.go
*use correct encoding method
*use crypto/multikey.PublicKeyFromBytes
*create tests using external files
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 6, 2020
@developerfred
feat: getting key from hex mailchain#52
f75181e
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 6, 2020
@developerfred
feat: getting key from hex mailchain#52
4c29b9f
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 6, 2020
@developerfred
feat: getting key from hex mailchain#52
3c6d212
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 6, 2020
@developerfred
add test file for PublicKeyEncoding() mailchain#52
a8f34b6
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 7, 2020
@developerfred
add test file for PublicKeyEncoding() mailchain#52
a309f98
developerfred added a commit to developerfred/mailchain that referenced this issue Feb 7, 2020
@developerfred
add test file for PublicKeyEncoding() mailchain#52
195db16
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work for 60.0 SAI (60.0 USD @ $1.0/SAI) has been submitted by:

  1. @developerfred

@Web3Foundation please take a look at the submitted work:

robdefeo added a commit that referenced this issue Feb 7, 2020
@developerfred @robdefeo
feat: getting key from hex (#540)
92501ba 
*  [x] use correct encoding method from encoding package to decode bytes #52

* expand PostMessage in cmd/mailchain/internal/http/handlers/send_message.go to include public-key-encoding and public-key-kind #52

*validate public_key_encoding use encoding/consts.go
*use correct encoding method
*use crypto/multikey.PublicKeyFromBytes
*create tests using external files

* feat: getting key from hex #52

* *add function encoding.PublicKeyEncoding

* update send_message_test

* add test file for PublicKeyEncoding()  #52

* tests: increase test coverage

Co-authored-by: Rob De Feo <robertodefeo@hotmail.com>
@stale
Copy link

stale bot commented Jun 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. The resources of the Mailchain team are limited, and so we are asking for your help. If this is a bug and you can still reproduce this error on the master branch, please reply in order to keep the issue open. If this is a feature request, and you feel that it is still relevant and valuable, please reply in order to keep the issue open. This issue will automatically be closed in the near future if no further activity occurs. Thank you for all your contributions.

@stale stale bot added the Stale label Jun 6, 2020
protocol/substrate automation moved this from To do to Done Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@developerfred developerfred

Labels
area/sender bounty-awaiting-approval bounty-xs cmd/mailchain protocol/substrate Stale
Projects
protocol/substrate
  
Done
Milestone
v0.1.0
Development

No branches or pull requests
6 participants
@robdefeo @sameer2800 @olimpias @gitcoinbot @Web3Foundation @developerfred