feat: sr25519 #360

developerfred · 2019-11-10T17:34:41Z

sr25519 - Module

accept address polkadot/substrate
sr22519 wait for [32]byte to input (seed,privateKey, Publickey) and respose with keys [32]bytes.

Struct files: Package sr25519 schnorrkel

.
+-- sr25519 
|   +-- sr25519test
|   |   +-- keys.go
|   +-- private.go
|   +-- public.go
|   +-- public_test.go
|   +-- end_end_test.go

Default Functions

PublicKeyFromBytes()
PrivateKeyFromBytes()

Nacl

decrypter
encrypter

fixes #327
fixes #505

robdefeo

Hi @developerfred this is a difficult issue and this looks like a promising start :) I have added some comments to the PR and also expanded the issue to clarify the scope a bit more.

I also added the prefered keys to use for sofia and charlotte this way its easier to reliably test the PR.

Thank you for your initial work on this.

crypto/secp256k1/private.go

.gitignore

.golangci.yml

cmd/mailchain/commands/account.go

crypto/cipher/nacl/end_end_test.go

crypto/cipher/nacl/nacl_test.go

crypto/sr25519/keys_test.go

crypto/sr25519/private.go

golangcibot · 2019-12-17T17:46:16Z

crypto/sr25519/private.go

+func (pk PrivateKey) Bytes() []byte {
+	b := pk.key
+
+	return b[:]


unslice: could simplify b[:] to b (from gocritic)

golangcibot · 2020-01-24T21:33:56Z

crypto/sr25519/sr25519test/keys.go

+)
+
+// SofiaPrivateKey sr25519 key for testing purposes. Key is compromised do not use on mainnet's.
+var SofiaPrivateKey crypto.PrivateKey //nolint: gochecknoglobals


whyNoLint: include an explanation for nolint directive (from gocritic)

golangcibot · 2020-01-24T21:33:56Z

crypto/sr25519/sr25519test/keys.go

+// SofiaPrivateKey sr25519 key for testing purposes. Key is compromised do not use on mainnet's.
+var SofiaPrivateKey crypto.PrivateKey //nolint: gochecknoglobals
+// SofiaPublicKey sr25519 key for testing purposes. Key is compromised do not use on mainnet's.
+var SofiaPublicKey crypto.PublicKey //nolint: gochecknoglobals


whyNoLint: include an explanation for nolint directive (from gocritic)

golangcibot · 2020-01-24T21:33:56Z

crypto/sr25519/sr25519test/keys.go

+// SofiaPublicKey sr25519 key for testing purposes. Key is compromised do not use on mainnet's.
+var SofiaPublicKey crypto.PublicKey //nolint: gochecknoglobals
+// CharlottePrivateKey sr25519 key for testing purposes. Key is compromised do not use on mainnet's.
+var CharlottePrivateKey crypto.PrivateKey //nolint: gochecknoglobals


whyNoLint: include an explanation for nolint directive (from gocritic)

golangcibot · 2020-01-24T21:33:57Z

crypto/sr25519/sign.go

+	return k.FromUniformBytes(b)
+}
+
+func witness(nonce []byte) (*ristretto255.Scalar, error) {


witness - nonce is unused (from unparam)

golangcibot · 2020-01-24T21:33:57Z

crypto/internal/schnorrkel/secretkey.go

+	h := sha512.Sum512(seed[:])
+	key := [32]byte{}
+	nonce := [32]byte{}
+	copy(key[:], h[:32])


only cuddled expressions if assigning variable or using from line above (from wsl)

golangcibot · 2020-01-24T21:33:59Z

crypto/sr25519/public.go

+	if err := a.Decode(pk.key); err != nil {
+		return false
+	}
+	Rp := ristretto255.NewElement()


assignments should only be cuddled with other assignments (from wsl)

golangcibot · 2020-01-24T21:34:00Z

crypto/internal/schnorrkel/secretkey.go

+
+// https://github.com/w3f/schnorrkel/blob/718678e51006d84c7d8e4b6cde758906172e74f8/src/scalars.rs#L18
+func divideScalarByCofactor(s []byte) []byte {
+	l := len(s) - 1


mnd: Magic number: 1, in detected (from gomnd)

golangcibot · 2020-01-24T21:34:00Z

crypto/internal/schnorrkel/secretkey.go

+	l := len(s) - 1
+	low := byte(0)
+	for i := range s {
+		r := s[l-i] & 0b00000111 // remainder


mnd: Magic number: 0b00000111, in detected (from gomnd)

golangcibot · 2020-01-24T21:34:00Z

crypto/internal/schnorrkel/secretkey.go

+		r := s[l-i] & 0b00000111 // remainder
+		s[l-i] >>= 3
+		s[l-i] += low
+		low = r << 5


mnd: Magic number: 5, in detected (from gomnd)

golangcibot · 2020-01-24T21:34:01Z

crypto/sr25519/sign.go

+}
+
+func (s *signature) Decode(sig []byte) error { // https://github.com/w3f/schnorrkel/blob/4112f6e8cb684a1cc6574f9097497e1e302ab9a8/src/sign.rs#L114
+	if len(sig) != 64 {


mnd: Magic number: 64, in detected (from gomnd)

golangcibot · 2020-01-24T21:46:25Z

crypto/sr25519/sr25519test/keys.go

+// CharlottePublicKey sr25519 key for testing purposes. Key is compromised do not use on mainnet's.
+var CharlottePublicKey crypto.PublicKey //nolint: gochecknoglobals test key
+
+//nolint: gochecknoinits


whyNoLint: include an explanation for nolint directive (from gocritic)

golangcibot · 2020-01-24T21:46:25Z

crypto/sr25519/sr25519test/keys.go

+//nolint: gochecknoinits
+func init() {
+	var err error
+	SofiaPrivateKey, err = sr25519.PrivateKeyFromBytes(encodingtest.MustDecodeHex("5c6d7adf75bda1180c225d25f3aa8dc174bbfb3cddee11ae9a85982f6faf791a")) //nolint: lll


whyNoLint: include an explanation for nolint directive (from gocritic)

golangcibot · 2020-01-24T21:46:26Z

crypto/sr25519/sr25519test/keys.go

+
+	SofiaPublicKey = SofiaPrivateKey.PublicKey()
+
+	CharlottePrivateKey, err = sr25519.PrivateKeyFromBytes(encodingtest.MustDecodeHex("23b063a581fd8e5e847c4e2b9c494247298791530f5293be369e8bf23a45d2bd")) //nolint: lll


whyNoLint: include an explanation for nolint directive (from gocritic)

golangcibot · 2020-01-24T21:46:26Z

crypto/sr25519/sign.go

+	// form k
+	b := c.ExtractBytes(label, 64)
+	k := ristretto255.NewScalar()
+	return k.FromUniformBytes(b)


return statements should not be cuddled if block has more than two lines (from wsl)

golangcibot · 2020-01-24T21:46:26Z

crypto/sr25519/sign.go

+	copy(out[:32], s.R.Encode([]byte{}))
+	copy(out[32:], s.S.Encode([]byte{}))
+	out[63] |= 128
+	return out


return statements should not be cuddled if block has more than two lines (from wsl)

golangcibot · 2020-01-24T21:46:27Z

crypto/sr25519/sign.go

+	sig[63] &= 127
+
+	s.S = ristretto255.NewScalar()
+	return s.S.Decode(sig[32:])


return statements should not be cuddled if block has more than two lines (from wsl)

golangcibot · 2020-01-24T21:46:27Z

crypto/internal/schnorrkel/secretkey.go

+
+// https://github.com/w3f/schnorrkel/blob/718678e51006d84c7d8e4b6cde758906172e74f8/src/scalars.rs#L18
+func divideScalarByCofactor(s []byte) []byte {
+	l := len(s) - 1


mnd: Magic number: 1, in detected (from gomnd)

golangcibot · 2020-01-24T21:46:27Z

crypto/internal/schnorrkel/secretkey.go

+	low := byte(0)
+
+	for i := range s {
+		r := s[l-i] & 0b00000111 // remainder


mnd: Magic number: 0b00000111, in detected (from gomnd)

golangcibot · 2020-01-24T21:46:28Z

crypto/internal/schnorrkel/secretkey.go

+		r := s[l-i] & 0b00000111 // remainder
+		s[l-i] >>= 3
+		s[l-i] += low
+		low = r << 5


mnd: Magic number: 5, in detected (from gomnd)

golangcibot · 2020-01-24T21:46:28Z

crypto/sr25519/sign.go

+}
+
+func (s *signature) Decode(sig []byte) error { // https://github.com/w3f/schnorrkel/blob/4112f6e8cb684a1cc6574f9097497e1e302ab9a8/src/sign.rs#L114
+	if len(sig) != 64 {


mnd: Magic number: 64, in detected (from gomnd)

golangcibot · 2020-01-24T22:01:55Z

crypto/cipher/ecdh/sr25519.go

+	if err != nil {
+		return nil, ErrSharedSecretGenerate
+	}
+	return sharedSecret[:], nil


return statements should not be cuddled if block has more than two lines (from wsl)

golangcibot · 2020-01-24T22:01:55Z

crypto/sr25519/sign.go

+}
+
+func (s *signature) Decode(sig []byte) error { // https://github.com/w3f/schnorrkel/blob/4112f6e8cb684a1cc6574f9097497e1e302ab9a8/src/sign.rs#L114
+	if len(sig) != 64 {


mnd: Magic number: 64, in detected (from gomnd)

robdefeo

Thanks @developerfred for all your contributions to this PR 😄 change look good, its ready to merge 👍

developerfred force-pushed the issue/327 branch 6 times, most recently from b684305 to 7674149 Compare November 11, 2019 23:40

developerfred changed the title ~~[WIP] sr25519~~ [Feature] sr25519 Nov 11, 2019

developerfred force-pushed the issue/327 branch 9 times, most recently from ae7d99e to b629749 Compare November 12, 2019 16:52

developerfred changed the title ~~[Feature] sr25519~~ #327 [Feature] sr25519 Nov 12, 2019

robdefeo requested changes Nov 12, 2019

View reviewed changes

developerfred force-pushed the issue/327 branch 3 times, most recently from 23fe085 to d6207c2 Compare November 17, 2019 00:01

developerfred added 9 commits November 17, 2019 20:55

[WIP] mailchain#327 - start struct folders

01a5785

add new key sr25519

c03165f

[WIP] - private.go sr25519

1155696

[WIP - mailchain#327] public key add

b48d40d

[WIP] mailchain#327 add test rules

1e0a11c

add files on go.mod and fixed ristreto to ristretto

5d43459

[WIP] - create sr25519 module

8eb11d8

[WIP] public.go done[x] need test file

f69488f

[WIP]mailchain#327 - Public and Keys test files

e40fa5c

golangcibot reviewed Dec 16, 2019

View reviewed changes

crypto/sr25519/private.go Outdated Show resolved Hide resolved

developerfred force-pushed the issue/327 branch from c4ab1a6 to 48e688e Compare December 16, 2019 20:18

golangcibot reviewed Dec 16, 2019

View reviewed changes

crypto/sr25519/private.go Outdated Show resolved Hide resolved

developerfred force-pushed the issue/327 branch from 48e688e to 24e95be Compare December 17, 2019 17:44

golangcibot reviewed Dec 17, 2019

View reviewed changes

[ ] Nacl Error

9fb5149

developerfred force-pushed the issue/327 branch 2 times, most recently from c408023 to 9fb5149 Compare December 18, 2019 21:56

This was referenced Jan 5, 2020

create a key exchange for sr25519 package #505

Closed

feat: create a key exchange for ed25519 package and sr25519 package #506

Closed

Merge remote-tracking branch 'upstream/master' into issue/327

b996e14

developerfred changed the title ~~feat: sr25519 #327~~ feat: sr25519 Jan 6, 2020

feat: create key exchange for sr25519 package mailchain#505

a0a714f

developerfred force-pushed the issue/327 branch from 86afdc7 to a0a714f Compare January 6, 2020 01:33

robdefeo added 4 commits January 23, 2020 21:14

native sr25519

28ca25a

Merge branch 'master' into issue/327

19bf170

Merge branch 'master' into issue/327

1fcc665

create key exchange for sr25519

09bdc0a

golangcibot reviewed Jan 24, 2020

View reviewed changes

fix linting

8d04f59

golangcibot reviewed Jan 24, 2020

View reviewed changes

fix linting

b9bfa24

golangcibot reviewed Jan 24, 2020

View reviewed changes

robdefeo added 2 commits January 24, 2020 22:06

fix linting

40b64ef

more tests

25436d9

robdefeo added this to In progress in protocol/substrate via automation Jan 24, 2020

protocol/substrate automation moved this from In progress to Reviewer approved Jan 24, 2020

robdefeo approved these changes Jan 24, 2020

View reviewed changes

robdefeo merged commit b4be010 into mailchain:master Jan 24, 2020

protocol/substrate automation moved this from Reviewer approved to Done Jan 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: sr25519 #360

feat: sr25519 #360

developerfred commented Nov 10, 2019 •

edited by robdefeo

Loading

robdefeo left a comment

golangcibot Dec 17, 2019

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

golangcibot Jan 24, 2020

robdefeo left a comment


		SofiaPublicKey = SofiaPrivateKey.PublicKey()

		CharlottePrivateKey, err = sr25519.PrivateKeyFromBytes(encodingtest.MustDecodeHex("23b063a581fd8e5e847c4e2b9c494247298791530f5293be369e8bf23a45d2bd")) //nolint: lll

feat: sr25519 #360

feat: sr25519 #360

Conversation

developerfred commented Nov 10, 2019 • edited by robdefeo Loading

sr25519 - Module

Struct files: Package sr25519 schnorrkel

Default Functions

Nacl

robdefeo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robdefeo left a comment

Choose a reason for hiding this comment

developerfred commented Nov 10, 2019 •

edited by robdefeo

Loading