Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create a key exchange for sr25519 package #505

Closed
robdefeo opened this issue Jan 5, 2020 · 0 comments · Fixed by #360
Closed

create a key exchange for sr25519 package #505

robdefeo opened this issue Jan 5, 2020 · 0 comments · Fixed by #360
Labels
area/crypto crypto/sr25519 enhancement New feature or request
Projects
protocol/substrate

Comments

@robdefeo
Copy link
Member

robdefeo commented Jan 5, 2020

Is your feature request related to a problem? Please describe.
To use symmetric encryption methods with sr25519 ref #360 a key exchange is required.

Describe the solution you'd like
Implement the crypto.KeyExchange interface for sr25519 keys using ECDH ref #496
developerfred added a commit to developerfred/mailchain that referenced this issue Jan 5, 2020
@developerfred
feat: create a key exchange for ed25519 package mailchain#504 and sr2…
8057a13 
…5519 packange mailchain#505
developerfred added a commit to developerfred/mailchain that referenced this issue Jan 6, 2020
@developerfred
feat: create key exchange for sr25519 package mailchain#505
86afdc7
developerfred added a commit to developerfred/mailchain that referenced this issue Jan 6, 2020
@developerfred
feat: create key exchange for sr25519 package mailchain#505
a0a714f
@developerfred developerfred mentioned this issue Jan 24, 2020
Merged
2 tasks
@robdefeo robdefeo added this to To do in protocol/substrate via automation Jan 24, 2020
protocol/substrate automation moved this from To do to Done Jan 24, 2020
robdefeo added a commit that referenced this issue Jan 24, 2020
@developerfred @robdefeo
feat: implement sr25519 keys (#360)
b4be010 
* [WIP] #327 - start struct folders

* add new key sr25519

* [WIP] - private.go sr25519

* [WIP - #327] public key add

* [WIP] #327 add test rules

* add files on go.mod and fixed ristreto to ristretto

* [WIP] - create sr25519 module

* [WIP] public.go done[x] need test file

* [WIP]#327 - Public and Keys test files

* [WIP]test keys file

* #327 add function PrivateKeyfromBytes

* add news rules on go.mod

* Review this go.mod and go.sum

* add strobe/debug on .gitignore

* fixed tests

* fixed package ristretto 255

* fixed ristretto on private key

* fixed ristretto module

*  #327 merlin fixed

* change merlin version

*  update go mod

* fixed go get -v ./..

* fixed versions on go.md

* fixed version to 0.1.3

	modified:   go.mod
	modified:   ../../go.mod
	go.sum

* fixed sr25519 package

	modified:   crypto/sr25519/go.mod

* 	modified:   ../../.golangci.yml
	modified:   ../../cmd/mailchain/commands/account.go
	modified:   ../multikey/private_test.go
	deleted:    go.mod

	modified:   .golangci.yml
	modified:   cmd/mailchain/commands/account.go
	modified:   crypto/multikey/private_test.go
	deleted:    crypto/sr25519/go.mod
	modified:   crypto/sr25519/public.go

* #327 add sr25519 on nacl files

* - #327 Create go mod for sr25519

- add news rules on .gitignore
- fixed problens on ristretto package

	modified:   .gitignore

	modified:   crypto/sr25519/keys_test.go
	modified:   crypto/sr25519/public.go
	modified:   crypto/sr25519/sr25519test/keys.go

	new file:   go.mod

	modified:   crypto/cipher/nacl/nacl_test.go
	new file:   go.mod

	new file:   go.mod
	new file:   go.sum

	new file:   go.mod

	modified:   .gitignore
	modified:   crypto/cipher/nacl/nacl_test.go
	modified:   crypto/sr25519/keys_test.go
	modified:   crypto/sr25519/private.go
	modified:   crypto/sr25519/public.go
	modified:   crypto/sr25519/sr25519test/keys.go
	new file:   go.mod
	new file:   go.sum

*  #327 - update sr25519

 Changes to be committed:
	modified:   private.go
	modified:   public.go
	modified:   sr25519test/keys.go
	modified:   keys_test.go
	modified:   ../../go.mod

*  #327 - update sr25519

 Changes to be committed:
	modified:   private.go
	modified:   public.go
	modified:   sr25519test/keys.go
	modified:   keys_test.go
	modified:   ../../go.mod

* sr25519: cipher ncl #327 [x]

* add new function for converte string in byte array

* sr25519: [x] KeyPair
- [x] Charlotte and Sofie Tests
- [x] PrivateKeyToBytes

* add keys of thes sr25519

* [WIP] #327 - start struct folders

* add new key sr25519

* [WIP] - private.go sr25519

* [WIP - #327] public key add

* [WIP] #327 add test rules

* add files on go.mod and fixed ristreto to ristretto

* [WIP] - create sr25519 module

* [WIP] public.go done[x] need test file

* [WIP]#327 - Public and Keys test files

* [WIP]test keys file

* #327 add function PrivateKeyfromBytes

* add news rules on go.mod

* Review this go.mod and go.sum

* add strobe/debug on .gitignore

* fixed tests

* fixed package ristretto 255

* fixed ristretto on private key

* fixed ristretto module

*  #327 merlin fixed

* change merlin version

*  update go mod

* fixed go get -v ./..

* fixed versions on go.md

* fixed version to 0.1.3

	modified:   go.mod
	modified:   ../../go.mod
	go.sum

* fixed sr25519 package

	modified:   crypto/sr25519/go.mod

* #327 add sr25519 on nacl files

* sr25519: cipher ncl #327 [x]

* add new function for converte string in byte array

* Review this go.mod and go.sum

* 	modified:   ../../.golangci.yml
	modified:   ../../cmd/mailchain/commands/account.go
	modified:   ../multikey/private_test.go
	deleted:    go.mod

	modified:   .golangci.yml
	modified:   cmd/mailchain/commands/account.go
	modified:   crypto/multikey/private_test.go
	deleted:    crypto/sr25519/go.mod
	modified:   crypto/sr25519/public.go

* - #327 Create go mod for sr25519

- add news rules on .gitignore
- fixed problens on ristretto package

	modified:   .gitignore

	modified:   crypto/sr25519/keys_test.go
	modified:   crypto/sr25519/public.go
	modified:   crypto/sr25519/sr25519test/keys.go

	new file:   go.mod

	modified:   crypto/cipher/nacl/nacl_test.go
	new file:   go.mod

	new file:   go.mod
	new file:   go.sum

	new file:   go.mod

	modified:   .gitignore
	modified:   crypto/cipher/nacl/nacl_test.go
	modified:   crypto/sr25519/keys_test.go
	modified:   crypto/sr25519/private.go
	modified:   crypto/sr25519/public.go
	modified:   crypto/sr25519/sr25519test/keys.go
	new file:   go.mod
	new file:   go.sum

*  #327 - update sr25519

 Changes to be committed:
	modified:   private.go
	modified:   public.go
	modified:   sr25519test/keys.go
	modified:   keys_test.go
	modified:   ../../go.mod

* sr25519: cipher ncl #327 [x]

* add keys of thes sr25519

* Delete go.sum

* [WIP] sr25519

* suggest changes

* update keys on sr25519

* - [x] TestPrivateKey
- [x] TestPublicKey

* sr25519

* sr25519

* add sr25519 on multikey

* gofmt on sr25519

*  sr25519test/keys.go

* change msg err

* add charlotte sr25519 on multikey

*  add encodingtest.MustDecodeHex

* add encodingtest.MustDecodeHex on ed25519

* add encodingtest.MustDecodeHex on ed25519

	new file:   crypto/sr25519/end_end_test.go

* [WIP] TestPrivateKey_PublicKey same key

*  TestPrivateKey_public fail

*  PublicKey()

*  Publickey is working

*  sr25519: PrivateKey to PulicKey() [x]

* remove keypair.go

* update: address_test add #sr25519

* remove encoding and decoding

*  *[x] Add test case for sr25519 in TestEncrypter_Encrypt crypto/cipher/nacl/encrypt_test.go

* [x] add end_end_test
[x] sign/verify tests
[x] encrypt decrypt tests with nacl

* [ ] Nacl Error

* feat: create key exchange for sr25519 package #505

* native sr25519

* create key exchange for sr25519

* fix linting

* fix linting

* fix linting

* more tests

Co-authored-by: Rob De Feo <robertodefeo@hotmail.com>
This was referenced Feb 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/crypto crypto/sr25519 enhancement New feature or request
Projects
protocol/substrate
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: sr25519 developerfred/mailchain
1 participant
@robdefeo